Make ViewCompilation an MSBuild target #49

ryanbrandenburg · 2016-12-29T18:02:15Z

Including Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design should now add the Precompile target, which will run after publishing.

dnfclas · 2016-12-29T18:02:19Z

Hi @ryanbrandenburg, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

pranavkm · 2016-12-29T18:32:27Z

RazorViewCompilation.sln

 Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.Test", "test\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.Test\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.Test.xproj", "{E0D75B4E-839F-4F80-9B1F-B33F616BCC5F}"
 EndProject
+Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design", "src\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.xproj", "{D7F82DFE-7570-4824-9B2B-67255443D262}"


Should we rename this package to Microsoft.AspNetCore.Mvc.Razor.ViewCompilation? cc @Eilon \ @DamianEdwards

Code organization \ engineering issues aside, we can now make Microsoft.AspNetCore.Mvc depend on this package. By setting <MvcBuildViews>true</MvcBuildViews> (or something like that) in your project, we can make view compilation just work so you wouldn't actually need to know the package name anymore.

@DamianEdwards would have to be the one to answer that.

pranavkm · 2016-12-29T18:33:11Z

...Mvc.Razor.ViewCompilation.Design/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.xproj

@@ -6,11 +6,10 @@
  </PropertyGroup>
  <Import Project="$(VSToolsPath)\DotNet\Microsoft.DotNet.Props" Condition="'$(VSToolsPath)' != ''" />
  <PropertyGroup Label="Globals">
-    <ProjectGuid>4339fc9b-aec6-442a-b413-a41555ed76c7</ProjectGuid>


Could we keep this Guid the same? Fewer diffs

pranavkm · 2016-12-29T18:34:29Z

...vc.Razor.ViewCompilation.Design/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.nuspec

+    <serviceable>true</serviceable>
+  </metadata>
+  <files>
+    <file src="artifacts/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.dll" target="build/" />


What does the structure of the package look like? Also, does this work for net451 targeting apps? Might also need the crossTargeting target (https://github.com/aspnet/RazorTooling/blob/nimullen/msbuild.93/src/Microsoft.AspNetCore.Razor.Tools/buildCrossTargeting/Microsoft.AspNetCore.Razor.Tools.targets) to make this work for multi-targeting projects.

pranavkm · 2016-12-29T18:34:48Z

...vc.Razor.ViewCompilation.Design/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.nuspec

+    <id>Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design</id>
+    <version>1.2.0</version>
+    <authors>Microsoft</authors>
+    <owners>Microsoft</owners>


pranavkm · 2016-12-29T18:35:57Z

...vc.Razor.ViewCompilation.Design/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.nuspec

+<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
+  <metadata>
+    <id>Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design</id>
+    <version>1.2.0</version>


$Version$ and then pass this in as part of building the package.

pranavkm · 2016-12-29T18:57:55Z

src/global.json

@@ -1,6 +1,5 @@
 {
-  "projects": [],
  "sdk": {
    "version": "1.0.0-preview2-1-003177"


1.0.0-preview2-1-003180

pranavkm · 2016-12-29T18:59:45Z

testapps/NuGet.config

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <configuration>
  <packageSources>
-    <add key="LocalArtifacts" value="../artifacts/build" />
+    <add key="LocalArtifacts" value="../artifacts" />


We require the artifacts/build structure for Universe to be able to pick up packages.

pranavkm · 2016-12-29T19:00:34Z

test/global.json

@@ -0,0 +1,6 @@
+{


Can we change this to msbuild? It's weird to have a repo that's partially csproj and project.json.

pranavkm · 2016-12-29T19:02:47Z

testapps/SimpleApp/SimpleApp.csproj

@@ -0,0 +1,45 @@
+<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">


Microsoft.NET.Sdk.Web

pranavkm · 2016-12-29T19:03:33Z

testapps/SimpleApp/SimpleApp.csproj

+      <Version>1.2.0-*</Version>
+    </PackageReference>    
+    <PackageReference Include="Microsoft.NETCore.App">
+      <Version>1.0.0-*</Version>


ryanbrandenburg · 2016-12-30T23:01:17Z

🆙📅

DamianEdwards · 2016-12-30T23:12:24Z

...ion.Design/build/netcoreapp1.0/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.targets

+      <ExecArgs Condition="$(DelaySign) == true"
+        Include="--delay-sign" />
+    </ItemGroup>
+    <Exec Command="dotnet exec @(ExecArgs->'%(Identity)', ' ')" />


So the target effectively just executes the Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.dll using dotnet exec? Why isn't it just a task? Is this how we execute our "inside man"?

We played around with converting it to a Task. Unfortunately dotnet msbuild (the one's in the 1.0.0-preview4-004233 SDK) uses the 1.0.1 shared runtime. Precompilation references Mvc which is compiled against CoreFx 4.4.0 packages i.e versions newer than the one that are in the shared runtime running the task. This fails at runtime with errors like

D:\temp\msbuild-test\srcD:\temp\msbuild-test\src\src.csproj(4,5): error MSB4018: The "TestTask" task failed unexpectedly.\r D:\temp\msbuild-test\src\src.csproj(4,5): error MSB4018: System.IO.FileNotFoundException: Could not load file or assembly 'System.Collections.Immutable, Version=1.2.2.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.\r D:\temp\msbuild-test\src\src.csproj(4,5): error MSB4018: File name: 'System.Collections.Immutable, Version=1.2.2.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'\r D:\temp\msbuild-test\src\src.csproj(4,5): error MSB4018: at Microsoft.Test.TestTask.Test()\r D:\temp\msbuild-test\src\src.csproj(4,5): error MSB4018: at Microsoft.Test.TestTask.Execute()\r D:\temp\msbuild-test\src\src.csproj(4,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()\r D:\temp\msbuild-test\src\src.csproj(4,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__25.MoveNext()

Super simple repro here: https://github.com/pranavkm/msbuild-repro/tree/master/src. We'll follow up with the MSBuild team next week, but given that we're also going to be loading user code, I think we are going to run in to issues converting it into a task. The current approach avoids these.

pranavkm · 2016-12-30T23:10:58Z

makefile.shade

@@ -1,20 +1,18 @@
 use namespace="System.IO"

-BuildQuality = "preview4";
+- //BuildQuality = "preview4";


pranavkm · 2016-12-30T23:11:35Z

makefile.shade

@@ -1,20 +1,18 @@
 use namespace="System.IO"

-BuildQuality = "preview4";
+- //BuildQuality = "preview4";
 use-standard-lifecycle
 k-standard-goals

 #repo-initialize target='initialize'


Feel free to remove this node entirely. It should probably restore just fine.

pranavkm · 2016-12-30T23:12:33Z

makefile.shade

This should no longer be an issue, so we should remove this and start running tests.

pranavkm · 2016-12-30T23:14:48Z

packaging/pack.proj

+    <Import Project="..\build\common.props" />
+
+    <Target Name="Pack"> 
+        <MSBuild Projects="$(MSBuildThisFileDirectory)..\src\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.csproj"


Could you declare <SolutionRoot>$(GetDirectoryNameOfFileAbove(MvcPrecompilation.sln)/</SolutionRoot> and use that instead of doing $(MSBuildThisFileDirectory)..\ everywhere in this file?

pranavkm · 2016-12-30T23:15:29Z

...vc.Razor.ViewCompilation.Design/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.csproj

+    <Import Project="..\..\build\common.props" />
+    <PropertyGroup>
+        <Description>"Build-time references required to enable Razor view compilation as part of building the application."</Description>
+        <TargetFramework>netcoreapp1.0</TargetFramework>


netcoreapp1.2

I think we would have to cross-compile the binary since we load user code in the tool. Does it work for net451 targeting projects?

pranavkm · 2016-12-30T23:20:02Z

...lation.FunctionalTests/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests.csproj

+
+  <ItemGroup>
+    <Compile Include="**\*.cs" />
+    <EmbeddedResource Include="**\*.resx" Exclude="bin\**;obj\**;**\*.xproj;packages\**" />


Could we make this <EmbeddedResource Include="Resources\*"/> and remove all the exclusions?

pranavkm · 2016-12-30T23:20:19Z

...lation.FunctionalTests/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests.csproj

+
+  <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">
+    <PackageReference Include="Microsoft.NETCore.App">
+      <Version>1.0.0-*</Version>


pranavkm · 2016-12-30T23:20:25Z

...lation.FunctionalTests/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests.csproj

+    </PackageReference>
+  </ItemGroup>
+
+  <PropertyGroup Condition=" '$(Configuration)' == 'Release' ">


pranavkm · 2016-12-30T23:20:32Z

...iewCompilation.Design.Test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.Test.csproj

+    </PackageReference>
+  </ItemGroup>
+
+  <PropertyGroup Condition=" '$(Configuration)' == 'Release' ">


pranavkm · 2016-12-30T23:20:58Z

testapps/SimpleApp/SimpleApp.csproj

+<Project Sdk="Microsoft.NET.Sdk.Web" ToolsVersion="15.0">
+
+  <PropertyGroup>
+    <TargetFramework>netcoreapp1.0</TargetFramework>


netcoreapp1.2

DamianEdwards · 2016-12-30T23:38:09Z

Just a reminder this needs to work with apps targeting netcoreapp1.1, just like the project.json version did. I see tests targeting netcoreapp1.2 so figured I'd call it out.

natemcmaster · 2017-01-04T16:51:37Z

build/common.props

+    <Product>Microsoft ASP.NET Core</Product>
+    <RepositoryUrl>https://github.com/aspnet/MvcPrecompilation</RepositoryUrl>
+    <RepositoryType>git</RepositoryType>
+    <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)../tools/Key.snk</AssemblyOriginatorKeyFile>


For the sake of consistency, I've been moving Key.snk into the 'build' folder.

natemcmaster · 2017-01-04T16:52:10Z

build/common.props

+    <SignAssembly>true</SignAssembly>
+    <PublicSign Condition="'$(OS)' != 'Windows_NT'">true</PublicSign>
+
+    <GenerateNeutralResourcesLanguageAttribute>false</GenerateNeutralResourcesLanguageAttribute>


The SDK will generate assembly attributes now. You can delete these 4 attributes from AssemblyInfo.cs

natemcmaster · 2017-01-04T16:52:46Z

global.json

@@ -2,8 +2,5 @@
  "projects": [


You can delete this whole file.

natemcmaster · 2017-01-04T16:53:26Z

...vc.Razor.ViewCompilation.Design/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.csproj

+<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">    
+    <Import Project="..\..\build\common.props" />
+    <PropertyGroup>
+        <Description>"Build-time references required to enable Razor view compilation as part of building the application."</Description>


Remove the double quotes

natemcmaster · 2017-01-04T16:53:55Z

...vc.Razor.ViewCompilation.Design/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.csproj

+        <TargetFramework>netcoreapp1.2</TargetFramework>
+        <PackageTags>cshtml;razor;compilation;precompilation;aspnetcore</PackageTags>
+        <PreserveCompilationContext>true</PreserveCompilationContext>
+        <AssemblyName>Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design</AssemblyName>


You can remove this. This is the default value anyways.

natemcmaster · 2017-01-04T17:01:45Z

...lation.FunctionalTests/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests.csproj

@@ -0,0 +1,47 @@
+<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">


Same comments above apply to this file

natemcmaster · 2017-01-04T17:02:29Z

...lation.FunctionalTests/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests.csproj

+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk">
+      <Version>15.0.0-preview-20161024-02</Version>


Lift to 15.0.0-preview-20161123-03

natemcmaster · 2017-01-04T17:03:12Z

...iewCompilation.Design.Test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.Test.csproj

+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk">
+      <Version>15.0.0-preview-*</Version>


Recommend hard coding this to 15.0.0-preview-20161123-03. The VSTest team has decided (for some reason) to publish nighlies to nuget.org instead of myget.org. They're package is pretty volatile right now.

natemcmaster · 2017-01-04T17:05:36Z

...iewCompilation.Design.Test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.Test.csproj

+      <Version>15.0.0-preview-*</Version>
+    </PackageReference>
+    <PackageReference Include="xunit.runner.visualstudio">
+      <Version>2.2.0-beta4-*</Version>


Can be set to 2.2.0-*.

natemcmaster · 2017-01-04T17:07:39Z

testapps/SimpleApp/SimpleApp.csproj

+
+  <ItemGroup>
+    <EmbeddedResource Include="**\*.resx" />
+    <EmbeddedResource Include="compiler\resources\**\*" />


You can remove this. Was probably generated by dotnet-migrate, right? Didn't see any files in this folder so it's not necessary.

natemcmaster · 2017-01-04T22:45:55Z

RazorViewCompilation.sln

@@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 14


upgrade this file to dev15. You'll need to change the project GUID type from 8BB2217D-0F2D-49D1-97BC-3654ED321F3B to 9A19103F-16F7-4668-BE54-9A1E7A4F7556, and update these lines:

# Visual Studio 15 VisualStudioVersion = 15.0.26014.0

natemcmaster · 2017-01-04T22:47:26Z

version.props

+<!-- This file may be overwritten by automation. Only values allowed here are VersionPrefix and VersionSuffix.  -->
+<Project>
+    <PropertyGroup>
+        <VersionPrefix>1.2.0</VersionPrefix>


Should this still be 1.2.0, even though it has 1.1.0 dependencies?

natemcmaster · 2017-01-05T00:55:59Z

...ompilation.Design/build/net451/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Design.targets

+    <MvcRazorOutputPath Condition="'$(MvcRazorOutputPath)'==''">$(OutputPath)</MvcRazorOutputPath>
+    <MyGeneratedDll>$(AssemblyName).PrecompiledViews.dll</MyGeneratedDll>
+    <MyGeneratedDllPath>$(OutputPath)$(MyGeneratedDll)</MyGeneratedDllPath>
+    <BuildDependsOn>$(BuildDependsOn);MvcRazorPrecompile</BuildDependsOn>


...originally I thought this was the best way to go, but had a chat with MSBuild guys recently. 'AfterTargets' is the preferred way to do this. MSBuild is actually trying to get away from these 'dependson' chains.

natemcmaster · 2017-01-06T02:27:04Z

NuGet.config

@@ -3,5 +3,6 @@
  <packageSources>
    <add key="AspNetCore" value="https://dotnet.myget.org/F/aspnetcore-ci-dev/api/v3/index.json" />
    <add key="NuGet" value="https://api.nuget.org/v3/index.json" />
+    <add key="Local" value="D:\work\katana\Hosting\artifacts\build" />


Local dev feed?

pranavkm

Working through tests.

pranavkm · 2017-01-06T02:24:20Z

NuGet.config

@@ -3,5 +3,6 @@
  <packageSources>
    <add key="AspNetCore" value="https://dotnet.myget.org/F/aspnetcore-ci-dev/api/v3/index.json" />
    <add key="NuGet" value="https://api.nuget.org/v3/index.json" />
+    <add key="Local" value="D:\work\katana\Hosting\artifacts\build" />


Temporarily until I can get aspnet/Hosting#910 in.

pranavkm · 2017-01-06T02:25:55Z

src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Internal/PrecompilationApplication.cs

@@ -49,5 +51,22 @@ private string GetInformationalVersion()
            var attribute = assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>();
            return attribute.InformationalVersion;
        }
+
+        private static string[] ExpandResponseFiles(string[] args)


We need to pass in the ContentFiles node in rather than scanning for cshtml files to be correct. Setting this up as a first step to pass in args to the tool.

natemcmaster · 2017-01-06T02:52:32Z

testapps/StrongNamedApp/StrongNamedApp.csproj

@@ -0,0 +1,42 @@
+<Project Sdk="Microsoft.NET.Sdk.Web" ToolsVersion="15.0">


Nit: this and other testapps files can be cleaned up. Remove redundant attributes (AssemblyName), use one-line syntax for PackageReference, remove the unnecessary 'DefineConstants RELEASE' block at the end.

natemcmaster · 2017-01-06T02:53:32Z

testapps/SimpleApp/1.txt

@@ -0,0 +1,2598 @@
+<?xml version="1.0" encoding="utf-8"?>


Looks like this file shouldn't be in source control.

natemcmaster · 2017-01-06T02:57:04Z

src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Properties/AssemblyInfo.cs

@@ -5,7 +5,3 @@
 using System.Resources;

 [assembly: AssemblyMetadata("Serviceable", "True")]


Can remove this. Korebuild feature/msbuild adds this. cref https://github.com/aspnet/KoreBuild/blob/ee0383feffde791108402895fd0c60f5d16f1ad0/build/contentFiles/cs/any/AssemblyInfo.Serviceable.cs

natemcmaster · 2017-01-06T02:59:07Z

...t.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj

+
+    <ItemGroup>
+        <Compile Include="**\*.cs" />
+        <None Include="build/**/*.*" Pack="true" PackagePath="build/%(RecursiveDir)%(FileName)%(Extension)" />


Can be Include="build\**\*" in case there are extensionless files. Also, MSBuild convention is backslashes instead of forwardslashes (even on xplat).

Also, you can simplify to PackagePath="%(Identity)"

pranavkm · 2017-01-07T00:04:20Z

🆙 📅

natemcmaster

Per in-person discussion with Pranav, I suggest you look into including the assembly in the @(IntermediateAssembly) item group. But this can probably be done later as (from inspection) it seems the current targets produce the desired output.

natemcmaster · 2017-01-07T00:41:29Z

...r.ViewCompilation/build/netcoreapp1.1/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.targets

@@ -0,0 +1,23 @@
+<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <Import Project="../common.targets" />


Use $(MSBuildThisFileDirectory)

natemcmaster · 2017-01-10T18:31:26Z

...r.ViewCompilation/buildCrossTargeting/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.targets

@@ -0,0 +1,18 @@
+<!--


This file should be moved to buildMultiTargeting. Cref NuGet/Home#4098

ryanbrandenburg · 2017-01-11T19:10:54Z

@pranavkm has already made these fixes and merged them in, so I'm closing this out.

ryanbrandenburg assigned pranavkm and DamianEdwards Dec 29, 2016

dnfclas added the cla-already-signed label Dec 29, 2016

pranavkm suggested changes Dec 29, 2016

View reviewed changes

ryanbrandenburg force-pushed the rybrande/MsBuildTarget branch from 76f2d4d to 498a890 Compare December 30, 2016 22:05

DamianEdwards reviewed Dec 30, 2016

View reviewed changes

pranavkm suggested changes Dec 30, 2016

View reviewed changes

ryanbrandenburg mentioned this pull request Jan 3, 2017

Version conflict with imported packages dotnet/msbuild#1512

Closed

natemcmaster suggested changes Jan 4, 2017

View reviewed changes

natemcmaster reviewed Jan 4, 2017

View reviewed changes

natemcmaster reviewed Jan 5, 2017

View reviewed changes

pranavkm force-pushed the rybrande/MsBuildTarget branch from 9210571 to 0fd59af Compare January 6, 2017 02:26

natemcmaster reviewed Jan 6, 2017

View reviewed changes

pranavkm reviewed Jan 6, 2017

View reviewed changes

natemcmaster reviewed Jan 6, 2017

View reviewed changes

pranavkm force-pushed the rybrande/MsBuildTarget branch from 0fd59af to 195658b Compare January 7, 2017 00:04

pranavkm force-pushed the rybrande/MsBuildTarget branch from 195658b to 94bba14 Compare January 7, 2017 00:38

Make ViewCompilation a target

00b24f5

pranavkm force-pushed the rybrande/MsBuildTarget branch from 94bba14 to 00b24f5 Compare January 7, 2017 00:39

natemcmaster reviewed Jan 7, 2017

View reviewed changes

natemcmaster reviewed Jan 10, 2017

View reviewed changes

ryanbrandenburg closed this Jan 11, 2017

ryanbrandenburg deleted the rybrande/MsBuildTarget branch January 11, 2017 19:11

		@@ -0,0 +1,45 @@
		<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">

		@@ -0,0 +1,47 @@
		<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">

		@@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
		# Visual Studio 14

		@@ -0,0 +1,42 @@
		<Project Sdk="Microsoft.NET.Sdk.Web" ToolsVersion="15.0">

		@@ -5,7 +5,3 @@
		using System.Resources;

		[assembly: AssemblyMetadata("Serviceable", "True")]

		@@ -0,0 +1,23 @@
		<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
		<Import Project="../common.targets" />

Make ViewCompilation an MSBuild target #49

Make ViewCompilation an MSBuild target #49

Conversation

ryanbrandenburg commented Dec 29, 2016

dnfclas commented Dec 29, 2016

pranavkm Dec 29, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanbrandenburg commented Dec 30, 2016

DamianEdwards Dec 30, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DamianEdwards commented Dec 30, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pranavkm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pranavkm commented Jan 7, 2017

natemcmaster left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanbrandenburg commented Jan 11, 2017

pranavkm Dec 29, 2016 •

edited

Loading

DamianEdwards Dec 30, 2016 •

edited

Loading

DamianEdwards commented Dec 30, 2016 •

edited

Loading