This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Removed @helper directive #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -279,22 +273,19 @@ public void CSharpCodeGeneratorCorrectlyGeneratesDesignTimePragmasForUnfinishedE | |||
| [Fact] | |||
| public void CSharpCodeGeneratorCorrectlyGeneratesDesignTimePragmasMarkupAndExpressions() | |||
| { | |||
| //System.Diagnostics.Debugger.Launch(); | |||
|
⌚ just one more bit of cleanup |
| @@ -24,7 +24,6 @@ private void SetupDirectives() | |||
| MapDirectives(InheritsDirective, SyntaxConstants.CSharp.InheritsKeyword); | |||
| MapDirectives(FunctionsDirective, SyntaxConstants.CSharp.FunctionsKeyword); | |||
| MapDirectives(SectionDirective, SyntaxConstants.CSharp.SectionKeyword); | |||
| MapDirectives(HelperDirective, SyntaxConstants.CSharp.HelperKeyword); | |||
There was a problem hiding this comment.
You should be able to remove the SyntaxConstants.CSharp.HelperKeyword
|
⌚ |
|
Updated. |
|
|
once
|
Ensure this doesn't break anything in MVC then |
ajaybhargavb
force-pushed
the
remove-helper
branch
from
18db035 to
b3c6097
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #281
@NTaylorMullen