This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Added temporary parse error for helper directive #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -425,4 +425,7 @@ Instead, wrap the contents of the block in "{{}}": | |||
| <data name="TagHelperParseTreeRewriter_InvalidNestedTag" xml:space="preserve"> | |||
| <value>The &lt;{0}&gt; tag is not allowed by parent &lt;{1}&gt; tag helper. Only child tag helper(s) targeting tag name(s) '{2}' are allowed.</value> | |||
| </data> | |||
| <data name="ParseError_HelperDirectiveNotAvailable" xml:space="preserve"> | |||
| <value>The @helper directive is not available in Razor 4.</value> | |||
There was a problem hiding this comment.
Suggestions for error message welcome 😄
There was a problem hiding this comment.
The {0} directive is no longer supported.
Don't want to specify the version for when we rev, and also don't want to inline @helper because it may be localized.
|
⌚ |
|
Updated. |
| @@ -425,4 +425,7 @@ Instead, wrap the contents of the block in "{{}}": | |||
| <data name="TagHelperParseTreeRewriter_InvalidNestedTag" xml:space="preserve"> | |||
| <value>The &lt;{0}&gt; tag is not allowed by parent &lt;{1}&gt; tag helper. Only child tag helper(s) targeting tag name(s) '{2}' are allowed.</value> | |||
| </data> | |||
| <data name="ParseError_HelperDirectiveNotAvailable" xml:space="preserve"> | |||
| <value>The {0} directive is no longer supported.</value> | |||
|
|
once 
ajaybhargavb
force-pushed
the
helper-error
branch
from
d4bdfd9 to
845cc76
Compare
ajaybhargavb
force-pushed
the
helper-error
branch
from
845cc76 to
153ed57
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#472
@NTaylorMullen