-
Notifications
You must be signed in to change notification settings - Fork 38
Add options for cookie handling #113
Comments
This could be useful. It would be another reason we need #52. |
I made copy of classes in 1.1 branch to my prototype solution and commented out the check for cookie header. Application Insights started working after this. |
Doesn't ResponseCaching already ignore all Set-Cookie headers? |
It doesn't ignore these. It doesn't cache if this header is present. |
#128 is related. No caching also occurs if the Authorization HTTP header is present. My proposal is that when the Authorization HTTP header is present, the cached entry should be taken, the Authorization and Set-Cookie HTTP headers on it should be updated from the current request and the response returned. #52 would mean we could do this ourselves but I think the above should be built in to the middleware. |
This issue was moved to dotnet/aspnetcore#2609 |
It would be nice if there are options for cookies handling. Two things I can propose:
Second option is specially important as currently it is not possible to use Application Insights with response caching as AI uses cookies when browser-side diagnostics are enabled. I think in this case request cookies must be just copied to response to not delete them.
The text was updated successfully, but these errors were encountered: