This repository was archived by the owner on Dec 13, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 598
Implement the hybrid flow, unify code and authorization flows #456
Comments
After discussion it sounds like this is important to support. |
@Tratcher @Eilon I agree the branching logic could be improved.
It is not clear where we fire the SecurityTokenValidated notification. The main purpose of the 'authentication code received' notification in Katana was that we didn't redeem the code. Given that this is the OIDC handler, we could assume the code is for "user_info_endpoint' and NOT fire the event, but that may cut out some scenarios. |
Moving this to Backlog as we will be in RC2 ask mode very soon. If you feel strongly about this issue, please ping me. |
Yes, this is important. |
yes - absolutely! |
Tratcher
added a commit
that referenced
this issue
Feb 4, 2016
Tratcher
added a commit
that referenced
this issue
Feb 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We don't really implement the hybrid flow, we just do the implicit flow and then fire AuthorizationCodeReceived at the end and let you do it yourself. Using AuthorizationCodeReceived here is confusing as it fires in a different order than it would in the code flow, and means something different. It looks like we should just implement the hybrid flow, and do so before doing all of the token validations.
I think we could unify HandleCodeOnlyFlow and HandleIdTokenFlows by doing things in the following order:
The text was updated successfully, but these errors were encountered: