Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Google handler should include claim for profile image url #969

Closed
hempels opened this issue Sep 10, 2016 · 8 comments
Closed

Google handler should include claim for profile image url #969

hempels opened this issue Sep 10, 2016 · 8 comments

Comments

@hempels
Copy link

hempels commented Sep 10, 2016

Google returns the user's profile url as well as the profile image url. Currently only the profile url is included as a claim. The image is useful data and should be included as a claim also.

@Eilon
Copy link
Contributor

Eilon commented Sep 15, 2016

We generally don't include extra data because not all apps need them, and can make the cookie size get excessively large. However, we made it fairly easy to add the right scopes (if necessary), and then map the claims into the data you request.

@Eilon Eilon closed this as completed Sep 15, 2016
@Eilon Eilon added the wontfix label Sep 15, 2016
@hempels
Copy link
Author

hempels commented Sep 21, 2016

It is possible to map the claims, but having gone through the process, I'm not convinced it's easy. The method is not at all intuitive and is entirely undocumented apart from sample code. While I applaud the effort, as an end user the current solution is far too time consuming. I'm finding this to be fairly consistently the case with ASP.NET Core. My hope is that some of this prodding will prompt you guys to consider not just whether you've made something possible, but also whether you've made it useable.

@Eilon Eilon removed the wontfix label Sep 21, 2016
@Eilon Eilon reopened this Sep 21, 2016
@Eilon
Copy link
Contributor

Eilon commented Sep 21, 2016

@hempels understood, so I'm re-opening this issue. Can you give an example of what you found to be not easy, and perhaps propose a syntax that you would find to be easier to use?

@muratg
Copy link
Contributor

muratg commented Sep 22, 2016

We could potentially consider adding a feature where a user app can map a JSON filed to a claim to make this easier.

@Tratcher
Copy link
Member

Idea:
options.AddClaimMap(jsonKey, claimName, claimType);

@HaoK
Copy link
Member

HaoK commented Sep 22, 2016

We should just generalize the functionality that's currently hardcoded in Facebook/Google handler that's copying claims over into the default claim map, and let that be the source of truth for what's done before the creating ticket event is fired.

@Tratcher
Copy link
Member

Similar issue mapping custom challenge parameters: #990

@Eilon Eilon added this to the 1.2.0 milestone Oct 6, 2016
@StummeJ
Copy link

StummeJ commented Dec 15, 2016

@hempels do you remember what sample code explained how to do this custom mapping?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants