Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Add response_mode=query support for OpenID Connect #279

Merged
merged 1 commit into from
Jul 15, 2015
Merged

Add response_mode=query support for OpenID Connect #279

merged 1 commit into from
Jul 15, 2015

Conversation

@kevinchalet
Copy link
Contributor

@kevinchalet kevinchalet commented May 28, 2015

kevinchalet
kevinchalet reviewed May 28, 2015
View reviewed changes
src/Microsoft.AspNet.Authentication.OpenIdConnect/OpenIdConnectAuthenticationHandler.cs Outdated
Copy link
Contributor Author

@kevinchalet kevinchalet May 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move the hardcoded message to the .resx file when we're done with the other changes.

Copy link
Contributor Author

@kevinchalet kevinchalet Jun 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eilon is moving logging messages to .resx still the recommended approach?

@brentschmaltz
Copy link
Contributor

brentschmaltz commented May 29, 2015

I good with this PR, ack.

Tratcher
Tratcher reviewed May 29, 2015
View reviewed changes
src/Microsoft.AspNet.Authentication.OpenIdConnect/OpenIdConnectAuthenticationHandler.cs Outdated
Copy link
Member

@Tratcher Tratcher May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no empty line before an else statement.

Copy link
Contributor Author

@kevinchalet kevinchalet May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@Tratcher
Copy link
Member

Tratcher commented May 29, 2015

Looks good. Could use some tests.

@kevinchalet
Copy link
Contributor Author

kevinchalet commented May 29, 2015

@Tratcher yup, I agree, but the new OpenID Connect tests are a bit cryptic for me, I'm not sure where I'm supposed to add these tests.

@brentschmaltz a suggestion? 😄

@Eilon Eilon added this to the 1.0.0-beta6 milestone Jun 4, 2015
@Eilon
Copy link
Contributor

Eilon commented Jun 4, 2015

@Tratcher please merge when ready.

@Tratcher Tratcher self-assigned this Jun 4, 2015
@kevinchalet
Copy link
Contributor Author

kevinchalet commented Jun 5, 2015

@Eilon right now, merging this PR is pointless as it depends on #258, which doesn't seem to be ready yet.

kevinchalet
kevinchalet reviewed Jun 16, 2015
View reviewed changes
src/Microsoft.AspNet.Authentication.OpenIdConnect/OpenIdConnectAuthenticationHandler.cs
Copy link
Contributor Author

@kevinchalet kevinchalet Jun 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenIdConnectResponseTypes.CodeOnly has been renamed to OpenIdConnectResponseTypes.Code.

AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#156

@Tratcher
Copy link
Member

Tratcher commented Jul 14, 2015

@PinpointTownes I think all the PRs you need went in. Are you waiting on anything else? If not then please rebase.

@kevinchalet
Copy link
Contributor Author

kevinchalet commented Jul 14, 2015

@Tratcher I had planned to move the warning message to the .resx file, but according to @Eilon, this doesn't seem to be the appropriate approach anymore.

I'll rebase it when back home (you can cherry pick the unique commit if it's urgent)

@kevinchalet
Copy link
Contributor Author

kevinchalet commented Jul 15, 2015

@Tratcher rebased. As expected, there was no conflict 😄

@Tratcher Tratcher merged commit 54128e8 into aspnet:dev Jul 15, 2015
@kevinchalet kevinchalet mentioned this pull request Apr 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@Tratcher Tratcher

Labels

enhancement

Projects

None yet

Milestone

1.0.0-beta6

Development

Successfully merging this pull request may close these issues.

5 participants

@kevinchalet @brentschmaltz @Tratcher @Eilon @dnfclas