Add response_mode=query support for OpenID Connect #279
Conversation
| if (!string.IsNullOrWhiteSpace(message.IdToken) || | ||
| !string.IsNullOrWhiteSpace(message.Token)) | ||
| { | ||
| Logger.LogError("An OpenID Connect response cannot contain an identity token " + |
There was a problem hiding this comment.
I'll move the hardcoded message to the .resx file when we're done with the other changes.
There was a problem hiding this comment.
@Eilon is moving logging messages to .resx still the recommended approach?
|
I good with this PR, ack. |
| return null; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: no empty line before an else statement.
|
Looks good. Could use some tests. |
|
@Tratcher yup, I agree, but the new OpenID Connect tests are a bit cryptic for me, I'm not sure where I'm supposed to add these tests. @brentschmaltz a suggestion? 😄 |
|
@Tratcher please merge when ready. |
| // Omitting the response_mode parameter when it already corresponds to the default | ||
| // response_mode used for the specified response_type is recommended by the specifications. | ||
| // See http://openid.net/specs/oauth-v2-multiple-response-types-1_0.html#ResponseModes | ||
| if (!string.Equals(Options.ResponseType, OpenIdConnectResponseTypes.Code, StringComparison.Ordinal) || |
There was a problem hiding this comment.
OpenIdConnectResponseTypes.CodeOnly has been renamed to OpenIdConnectResponseTypes.Code.
AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#156
|
@PinpointTownes I think all the PRs you need went in. Are you waiting on anything else? If not then please rebase. |
|
@Tratcher rebased. As expected, there was no conflict 😄 |
Fixes #217
/cc @brentschmaltz @HaoK @Tratcher