-
Notifications
You must be signed in to change notification settings - Fork 597
Update MicrosoftAccount to use graph API & converged authentication #691
Conversation
-Updated MicrosoftAccountDefaults to use app model v2 & graph API -Updated MicrosoftAccountHelper to extract user info from the user object returned by the graph API -Updated MicrosoftAccountMiddlewareTests accordingly -Added the app model v2 client credentials to SocialSample/config.json -Configured SocialSample to use SSL
Hi @OsmanMElsayed, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
Very promising. @blowdart Are you aware of this transition for MSA? |
Yup. We ought to run this past @brentschmaltz et al. |
using Newtonsoft.Json.Linq; | ||
using System.Security.Cryptography.X509Certificates; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need sorting, with System on top.
- Sorted namespaces - Dropped openid scope from Microsoft-AccessToken project.json - Sorted dependencies MicrosoftAccountHelper.cs - Removed name claim transofmation - renamed GetName, GetFirstName & GetLastName
@OsmanMElsayed did you test this with an outlook.com account? I can't get it working, it keeps complaining about redirect uri mismatches no matter how I configure it. |
Does that happen with outlook accounts only or it applies to all Microsoft accounts? If it applies to all Microsoft accounts, then please make sure that the registered redirect uri for your app contains the configured |
Hooray! |
Rebased and merged. The problem I ran into was because my old local usersecrets were overwriting the config.json so I was using the wrong client id. |
Microsoft.AspNetCore.Authentication.MicrosoftAccount
package to target Microsoft graph API as Live Connect API & Identity API are depreciated. For this, we need to issue tokens from the app model v2.0 endpoints which will extend the reach of the package to all work/school accounts which is clearly a big added value.#92