comments

aspnet · Aug 15, 2018 · 91f55d1 · 91f55d1
1 parent 86b2f17
commit 91f55d1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/Microsoft.AspNetCore.SignalR.Core/Internal/HubMethodDescriptor.cs b/src/Microsoft.AspNetCore.SignalR.Core/Internal/HubMethodDescriptor.cs
@@ -33,8 +33,10 @@ public HubMethodDescriptor(ObjectMethodExecutor methodExecutor, IEnumerable<IAut
                 StreamReturnType = channelItemType;
             }
 
+            // Take out synthetic arguments that will be provided by the server, this list will be given to the protocol parsers
             ParameterTypes = methodExecutor.MethodParameters.Where(p =>
             {
+                // Only streams can take CancellationTokens currently
                 if (IsStreamable && p.ParameterType == typeof(CancellationToken))
                 {
                     HasSyntheticArguments = true;

diff --git a/src/Microsoft.AspNetCore.SignalR.Core/Internal/SyntheticArgumentsManager.cs b/src/Microsoft.AspNetCore.SignalR.Core/Internal/SyntheticArgumentsManager.cs
@@ -32,6 +32,7 @@ public bool TryGetSyntheticArgument(Type type, out object argument)
             return false;
         }
 
+        // May be used for canceling hub invocations, so we need to expose the cts
         public bool TryGetCancellationTokenSource(out CancellationTokenSource cts)
         {
             cts = _cts;