This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Microsoft.AspNetCore.Http.Connections.Client refactors #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JamesNK
commented
Apr 13, 2018
•
JamesNK
commented
- Internalize Constants
- Internalize DefaultTransportFactory
- Check in on current state of IAsyncDisposable, ensure DisposeAsync aligns as much as possible (current state is nothing concrete decided - IAsyncDisposable, using statements, and async/await dotnet/roslyn#114)
- Default to TransferFormat.Binary in StartAsync(TransferFormat) via overload
- Rename HttpConnectionOptions.AccessTokenFactory to AccessTokenProvider
- Internalize ITransport
- Internalize ITransportFactory
- Rename WebSocketOptions to WebSocketConfiguration
JamesNK
requested review from
analogrelay,
davidfowl,
mikaelm12 and
BrennanConroy
|
Build failure, bad merge? |
|
Bad merge. Will fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.