This repository was archived by the owner on Dec 18, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 446
Starting HubOptions #743
Merged
Merged
Starting HubOptions #743
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// Copyright (c) .NET Foundation. All rights reserved. | ||
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
||
using Newtonsoft.Json; | ||
|
||
namespace Microsoft.AspNetCore.SignalR | ||
{ | ||
public class HubOptions | ||
{ | ||
public JsonSerializerSettings JsonSerializerSettings { get; set; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,18 +3,26 @@ | |
|
||
using System; | ||
using Microsoft.AspNetCore.SignalR.Internal.Protocol; | ||
using Microsoft.Extensions.Options; | ||
using Newtonsoft.Json; | ||
|
||
namespace Microsoft.AspNetCore.SignalR.Internal | ||
{ | ||
public class DefaultHubProtocolResolver : IHubProtocolResolver | ||
{ | ||
private readonly IOptions<HubOptions> _options; | ||
|
||
public DefaultHubProtocolResolver(IOptions<HubOptions> options) | ||
{ | ||
_options = options; | ||
} | ||
|
||
public IHubProtocol GetProtocol(string protocolName, HubConnectionContext connection) | ||
{ | ||
switch (protocolName?.ToLowerInvariant()) | ||
{ | ||
case "json": | ||
return new JsonHubProtocol(new JsonSerializer()); | ||
return new JsonHubProtocol(JsonSerializer.Create(_options.Value.JsonSerializerSettings)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what settings are used if JsonSerializerSettings is null? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The default ones. Exact same as what we were doing before. |
||
case "messagepack": | ||
return new MessagePackHubProtocol(); | ||
default: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any concrete things to add here for alpha?