This repository was archived by the owner on Nov 22, 2018. It is now read-only.
Improve logging and add more messages #76
Merged
+200
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhurdugaci
force-pushed
the
victorhu/improve-logging
branch
from
5f168e3 to
966afe7
Compare
| { | ||
| if (_logger.IsEnabled(LogLevel.Verbose)) | ||
| { | ||
| _logger.LogVerbose(LoggingEventIds.MethodMismatch, $"{context.Request.Method} requests are not supported"); |
|
Take a look at aspnet/Mvc@da731fc - there's a super efficient and more slightly more cleanly pattern added recently |
|
Updated |
| static LoggerExtensions() | ||
| { | ||
| _logMethodNotSupported = LoggerMessage.Define<string>( | ||
| logLevel: LogLevel.Debug, |
There was a problem hiding this comment.
I talked to Ryan and he said that most of these should be Verbose, so you always end up with at least one verbose message when the middleware does not handle a request. If it does handle the request then there should be one or more Informational messages.
|
Updated |
| eventId: 5, | ||
| formatString: "The request path {Path} does not match an existing file"); | ||
| _logPathNotModified = LoggerMessage.Define<string>( | ||
| logLevel: LogLevel.Verbose, |
|
Updated again |
|
|
victorhurdugaci
force-pushed
the
victorhu/improve-logging
branch
from
8979a95 to
37f19b4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
please review @Tratcher @rynowak