Upgrade dnvm to beta8 #278
Conversation
|
Hi @natemcmaster, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| $env:DNX_HOME="$env:DNX_HOME;$env:DNX_GLOBAL_HOME" | ||
| $UnencodedHomes = "$UnencodedHomes;$GlobalHome" | ||
| } | ||
|
|
||
| $UnencodedHomes = $UnencodedHomes.Split(";") | ||
| $RuntimeHomes = $UnencodedHomes | ForEach-Object { [Environment]::ExpandEnvironmentVariables($_) } | ||
| $RuntimeDirs = $RuntimeHomes | ForEach-Object { Join-Path $_ "runtimes" } |
There was a problem hiding this comment.
Until we fix dotnet/aspnetcore#899 and / or aspnet/dnvm#422, we should not take this version of dnvm.ps1. The problem is that all variables in $UnencodedHomes are already expanded when [Environment]::ExpandEnvironmentVariables() is called above i.e. they're referenced before they are definitely defined -- $env:DNX_HOME and $env:DNX_GLOBAL_HOME in particular. That leads to failures because $_ is empty here.
|
⌚ |
|
See #288 |
Current version of dnvm is fairly old.