Skip to content
This repository has been archived by the owner on Oct 18, 2018. It is now read-only.

WebHooks for ASP.NET Core #5

Closed
smbecker opened this issue Sep 16, 2015 · 54 comments
Closed

WebHooks for ASP.NET Core #5

smbecker opened this issue Sep 16, 2015 · 54 comments
Assignees
Labels
cost: 0 Will take no time. This is a tracking issue enhancement Mapped to BigRock This issue is mapped to a big rock
Milestone

Comments

@smbecker
Copy link

Is there a plan to support ASP.NET 5?

@Eilon
Copy link
Member

Eilon commented Sep 16, 2015

Of course 😄

@garora
Copy link
Contributor

garora commented Sep 17, 2015

We have ASP.NET5 Beta7 released, so, what we are meant with the support of ASP.NET5?
I believe @HenrikFrystykNielsen - already planned 👍 and @Eilon already answered, awesome to read it.

@Eilon
Copy link
Member

Eilon commented Sep 17, 2015

There is no support yet for Web Hooks on ASP.NET 5. It currently works with ASP.NET 4.x only.

@garora
Copy link
Contributor

garora commented Sep 17, 2015

@Eilon thanks for confirming but as per your above reply, I understood that its in plan?

@Eilon
Copy link
Member

Eilon commented Sep 17, 2015

We intend to support it. There is no specific date.

@nicofr83
Copy link

Any news/date on this support ? I need to run a web hook under a linux box and I would hate to return to javascript/node... Thanks

@davidfowl davidfowl changed the title ASP.NET 5 support ASP.NET Core support Jan 20, 2016
@Eilon
Copy link
Member

Eilon commented Jan 20, 2016

Sorry no updates at this time.

@rposener
Copy link
Contributor

Just FYI - I have a pending pull request with mostly working port of the base and custom sender/receiver. Hopefully we will see this soon. Will need some help building up the supported receivers for the various supported hooks out of the box - if you want to help contribute those once the base stuff is sync'd in.

@Eilon
Copy link
Member

Eilon commented Mar 28, 2016

@rposener I do intend to take a look at it, but I just haven't yet found the time. It's kind of a big PR 😄

@Eilon Eilon self-assigned this Mar 28, 2016
@mikeesouth
Copy link

Any news? I am also intrested in this.

@rposener
Copy link
Contributor

Still waiting to hear from the asp.net core team. The code base has moved a lot since this pull request. Anyone interested is just writing out own since MS is being so slow? New tooling should be out this week helping us move onto CLI. Unless MS give confirmation that they will actually review and give input on a pull request to get this done. Kind of frustrating they are not embracing OSS community any more than this on this project!

@HenrikFrystykNielsen
Copy link
Contributor

I know this is frustrating and I apologize. With RC2 being out, my hope is that we can get some more cycles from the right people. Stay tuned!

@mikeesouth
Copy link

Can we help out somehow? I'm really waiting for this so being able to help our getting an ETA would be great :)

@rposener
Copy link
Contributor

The pull request is there, updated to rc2 with custom sender and receiver working in sample.

Might be good if you at minimum grabbed the source from pull source https://github.com/rposener/webhooks and gave it a test and provide comments.

Just need some review from asp.net team, and it to be merged in. If you want to fork a copy of the pull request and build xunit tests to convert the existing test sets. Then we just need to crank through the other receivers and samples.

@mikeesouth
Copy link

Unfortunately, I'm not much help here. I'm having troubles understanding your changes @rposener. The commits have thousands of changed files and I'm too new to loading custom libraries so I'm afraid I'm not much help here. I'll need some serious instructions on how to incorporate a custom built lib into an ASP.NET Core project. I would also like to use the Slack receiver but I assume I can mimic it with a custom receiver.
So, any help to get me on track or even better - an official merge into the core library would be great :)

@ups216
Copy link
Contributor

ups216 commented Jun 28, 2016

hi, asp.net core 1.0 is now RTM. Is there any progress on porting this to core?

@bragma
Copy link

bragma commented Jul 7, 2016

I'd really like to see this ported to Core too. Please do it! :)

@ArturKarbone
Copy link

@rposener, I just pulled your fork. Was not able to run it, since it's still requires RC2. Anyway I looked through the code. At the first glance it looks there are no breaking changes in terms of method's signatures/contracts.

However, there is something Core specific stuff, like initialization extensions, middleWare, etc.

I mean to support Core, WebHooks should support two code bases now, right? Otherwise previous package clients will be in trouble. Just wandering what is the best way to go here?

@tedvanderveen
Copy link

@Eilon as you assigned this issue to yourself, can you please update on status? With Core 1.0.0 released it would be a good time to look at the PR that @rposener invested time in developing?

@coderabsolute
Copy link

Any timelines to have the Webhook functionality released?

@BenHayat
Copy link

Is WH based on similar principals as SignalR? Do they overlap or complement each other?

Can't wait for these two to come to ASP.Net Core.

Thanks!
..Ben

@consigliory
Copy link

+1

4 similar comments
@divad4686
Copy link

+1

@SimoneBWS
Copy link

👍

@hasan-assi
Copy link

+1

@toast-gear
Copy link

+1

@Cafeffroi
Copy link

Any news about asp.net core support ?

@stodolos
Copy link

Any updates on Core support timeline?

@dougbu
Copy link
Member

dougbu commented Nov 11, 2017

Closing because remaining work is tracked in smaller issues. Though we'll reevaluate some design details and fill in gaps, the overall ASP.NET Core receiver basics and 10 receivers are in place.

@mkArtakMSFT
Copy link
Member

Reopening this as a high-level tracking item for all the receivers work for 2.1 release

@dougbu
Copy link
Member

dougbu commented Mar 1, 2018

What does "Working" mean here and why this issue is assigned to me? I have no action items I'm aware of that aren't already assigned to me.

We closed #5 when the port was complete and all known additional work for the 2.1 release (really 1.0 RTM) and beyond was tracked elsewhere.

@mkArtakMSFT
Copy link
Member

Removed the 2 - Working label as this is just an umbrella item, to track the rest of the work in this area for upcoming release.

@mkArtakMSFT mkArtakMSFT added the Mapped to BigRock This issue is mapped to a big rock label Mar 1, 2018
@dougbu dougbu modified the milestones: 1.0.0-preview1, 1.0.0 Mar 13, 2018
@dougbu dougbu added cost: S Will take up to 2 days to complete cost: 0 Will take no time. This is a tracking issue and removed cost: S Will take up to 2 days to complete labels Mar 15, 2018
@dougbu
Copy link
Member

dougbu commented Mar 15, 2018

Added cost - 0 since this is an umbrella tracking issue.

@dougbu
Copy link
Member

dougbu commented May 17, 2018

Suggest we un-assign this issue and remove the Mapped to Big Rock label.

Alternatively, could close this issue as well as aspnet/Specs#103.

@dougbu
Copy link
Member

dougbu commented Aug 3, 2018

@mkArtakMSFT @danroth27 @Eilon similar to aspnet/specs#103, I suggest we close this issue. Agreed?

@danroth27
Copy link
Member

I think we can close this since implementing WebHooks support for ASP.NET Core is what this repo is all about.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cost: 0 Will take no time. This is a tracking issue enhancement Mapped to BigRock This issue is mapped to a big rock
Projects
None yet
Development

No branches or pull requests