-
Notifications
You must be signed in to change notification settings - Fork 439
WebHooks for ASP.NET Core #5
Comments
Of course 😄 |
We have ASP.NET5 Beta7 released, so, what we are meant with the support of ASP.NET5? |
There is no support yet for Web Hooks on ASP.NET 5. It currently works with ASP.NET 4.x only. |
@Eilon thanks for confirming but as per your above reply, I understood that its in plan? |
We intend to support it. There is no specific date. |
Any news/date on this support ? I need to run a web hook under a linux box and I would hate to return to javascript/node... Thanks |
Sorry no updates at this time. |
Just FYI - I have a pending pull request with mostly working port of the base and custom sender/receiver. Hopefully we will see this soon. Will need some help building up the supported receivers for the various supported hooks out of the box - if you want to help contribute those once the base stuff is sync'd in. |
@rposener I do intend to take a look at it, but I just haven't yet found the time. It's kind of a big PR 😄 |
Any news? I am also intrested in this. |
Still waiting to hear from the asp.net core team. The code base has moved a lot since this pull request. Anyone interested is just writing out own since MS is being so slow? New tooling should be out this week helping us move onto CLI. Unless MS give confirmation that they will actually review and give input on a pull request to get this done. Kind of frustrating they are not embracing OSS community any more than this on this project! |
I know this is frustrating and I apologize. With RC2 being out, my hope is that we can get some more cycles from the right people. Stay tuned! |
Can we help out somehow? I'm really waiting for this so being able to help our getting an ETA would be great :) |
The pull request is there, updated to rc2 with custom sender and receiver working in sample. Might be good if you at minimum grabbed the source from pull source https://github.com/rposener/webhooks and gave it a test and provide comments. Just need some review from asp.net team, and it to be merged in. If you want to fork a copy of the pull request and build xunit tests to convert the existing test sets. Then we just need to crank through the other receivers and samples. |
Unfortunately, I'm not much help here. I'm having troubles understanding your changes @rposener. The commits have thousands of changed files and I'm too new to loading custom libraries so I'm afraid I'm not much help here. I'll need some serious instructions on how to incorporate a custom built lib into an ASP.NET Core project. I would also like to use the Slack receiver but I assume I can mimic it with a custom receiver. |
hi, asp.net core 1.0 is now RTM. Is there any progress on porting this to core? |
I'd really like to see this ported to Core too. Please do it! :) |
@rposener, I just pulled your fork. Was not able to run it, since it's still requires RC2. Anyway I looked through the code. At the first glance it looks there are no breaking changes in terms of method's signatures/contracts. However, there is something Core specific stuff, like initialization extensions, middleWare, etc. I mean to support Core, WebHooks should support two code bases now, right? Otherwise previous package clients will be in trouble. Just wandering what is the best way to go here? |
Any timelines to have the Webhook functionality released? |
Is WH based on similar principals as SignalR? Do they overlap or complement each other? Can't wait for these two to come to ASP.Net Core. Thanks! |
+1 |
4 similar comments
+1 |
👍 |
+1 |
+1 |
Any news about asp.net core support ? |
Any updates on Core support timeline? |
Closing because remaining work is tracked in smaller issues. Though we'll reevaluate some design details and fill in gaps, the overall ASP.NET Core receiver basics and 10 receivers are in place. |
Reopening this as a high-level tracking item for all the receivers work for 2.1 release |
What does "Working" mean here and why this issue is assigned to me? I have no action items I'm aware of that aren't already assigned to me. We closed #5 when the port was complete and all known additional work for the 2.1 release (really 1.0 RTM) and beyond was tracked elsewhere. |
Removed the |
Added |
Suggest we un-assign this issue and remove the Alternatively, could close this issue as well as aspnet/Specs#103. |
@mkArtakMSFT @danroth27 @Eilon similar to aspnet/specs#103, I suggest we close this issue. Agreed? |
I think we can close this since implementing WebHooks support for ASP.NET Core is what this repo is all about. |
Is there a plan to support ASP.NET 5?
The text was updated successfully, but these errors were encountered: