Add README to 2.1 folder explaining where the 2.1 images have gone #408
Conversation
2.1/README.md
Outdated
|
|
||
| In 2.1, the ASP.NET Core Docker images have migrated to https://github.com/dotnet/dotnet-docker. | ||
|
|
||
| **How can I upgrade from 1.x/2.0 to 2.1?** |
There was a problem hiding this comment.
I'm concerned that there is no mention of 2.1 still being in a preview state. If a reader isn't aware of the 2.1 status, this can give the false impression that upgrading from pre 2.1 to 2.1 is fine and dandy.
There was a problem hiding this comment.
I had the same concern about making the 2.1-sdk tag before RTM...but that ship sailed.
I can add a note about 2.1 being preview for now. I'm hoping that note is also prominent enough in the dotnet-docker README.
| You can either install NodeJS by adding a few lines of code to your Dockerfile that download and extract NodeJS, | ||
| or you can use the multi-stage feature of Docker and the official NodeJS images. | ||
|
|
||
| Sample code to install NodeJS on your own: |
There was a problem hiding this comment.
What sample do you see as the most common? I was thinking multi-stage using the NodeJS image would be. I think the most common sample should be listed first.
There was a problem hiding this comment.
It's sort of new territory since NodeJS has been bundled in the image until this point, so not sure which is more common. I would personally use multi-stage builds, but know lots of users have MSBuild targets invoking npm.
+1. Worth doing now, or once 2.1 RTMs? |
Follow up to #403 - For anyone coming to the repo and wondering what's up with 2.1...