dnvm global install #393
dnvm global install #393
Conversation
| @@ -82,6 +82,7 @@ $FullVersion="$ProductVersion-$BuildVersion" | |||
| Set-Variable -Option Constant "CommandName" ([IO.Path]::GetFileNameWithoutExtension($ScriptPath)) | |||
| Set-Variable -Option Constant "CommandFriendlyName" ".NET Version Manager" | |||
| Set-Variable -Option Constant "DefaultUserDirectoryName" ".dnx" | |||
| Set-Variable -Option Constant "DefaultGlobalDirectoryName" "Microsoft DNX" | |||
There was a problem hiding this comment.
Microsoft\DNX
A globally installed runtime should be at: %ProgramData%\Microsoft\DNX\runtimes\[version]\bin\...
There was a problem hiding this comment.
There is already a Microsoft DNX from breadcrumbs, so we decided to use that. We could still change if we want to
There was a problem hiding this comment.
We're synchronizing these folder layouts across a few things over time, so it's best to get everything right now :)
There was a problem hiding this comment.
Hmm... Ok... We'll have to consider that. /cc @davidfowl
There was a problem hiding this comment.
I don't like Microsoft DNX either, but it didn't seem bad enough to do the work to change it.
There was a problem hiding this comment.
Leave it Microsoft DNX for now, but we should make sure consider relocating this before RTM to be more consistent with everything else Microsoft :)
BrennanConroy
force-pushed
the
brecon/install_g
branch
from
4686d0c to
6402388
Compare
|
@anurse |
| echo " install latest $_DNVM_RUNTIME_SHORT_NAME from feed" | ||
| echo " adds $_DNVM_RUNTIME_SHORT_NAME bin to path of current command line" | ||
| echo " set installed version as default" | ||
| echo " -f|forces force upgrade. Overwrite existing version of $_DNVM_RUNTIME_SHORT_NAME if already installed" | ||
| echo " -u|unstable use unstable feed. Installs the $_DNVM_RUNTIME_SHORT_NAME from the unstable feed" | ||
| echo " -r|runtime The runtime flavor to install [clr or coreclr] (default: clr)" | ||
| echo " -g|global Installs the configured global dnx file location (default: /usr/local/lib/)" |
There was a problem hiding this comment.
How about something like Installs the latest $_DNVM_RUNTIME_SHORT_NAME in the configured global $_DNVM_RUNTIME_SHORTNAME file location (default: /usr/local/lib current: $DNX_GLOBAL_HOME)
There was a problem hiding this comment.
I'd remove the default part, just show ($DNX_GLOBAL_HOME). If the user changed the default, they know they changed it :)
|
sh looks ok to me. We're going to need some tests for global install. |
|
If this is needed for beta7, I'm willing to give a hesitant |
, but I'd like to see global install tests (which shouldn't be too hard given we have
| local answer= | ||
| if [ "$acceptSudo" == "0" ]; then | ||
| echo "In order to install dnx globally, dnvm will have to temporarily run as root." | ||
| read -p "You may be prompted for your password via 'sudo' during this process. Is this alright (y/n): " answer |
There was a problem hiding this comment.
"Is this alright" -> "Is this OK? (y/N)"
(Make the N capitalized and ensure that it is the default when nothing is typed)
|
sh changes look good to me. I think we might want a way for people to force install even if the runtime is installed in a different location. Imagine trying to "promote" a runtime you've already installed locally to the global store... right now we don't have a way to do that other than manually copying the directory. |
|
Take a look at the windows part? |
|
|
BrennanConroy
force-pushed
the
brecon/install_g
branch
from
5853f85 to
3eeb6cf
Compare
BrennanConroy
force-pushed
the
brecon/install_g
branch
from
3eeb6cf to
fc63c6c
Compare
@anurse @glennc
#414