This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Reorder dnvm.ps1 blocks to avoid read-before-write issues
#446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #422 - previously used `$env:DNX_HOME` or `$env:DNX_GLOBAL_HOME` when undefined - also ignores `$env:DNX_HOME` values such as ";C:\ProgramData\Microsoft DNX" nits: - use constants a bit more consistently - remove trailing whitespace
|
/cc @BrennanConroy |
| if(!$pf.EndsWith("\")) { $pf += "\" } | ||
| if($pf32 -and !$pf32.EndsWith("\")) { $pf32 += "\" } | ||
|
|
||
| $UserHome = $RuntimeHomes.Split(";") | Where-Object { |
There was a problem hiding this comment.
Added Split() and earlier if ($RuntimeHomes) because this block was currently after $RuntimeHomes was an array, not a string.
- clear if invalid or if set when performing a setup
- no more litedev feed
dougbu
force-pushed
the
dougbu/define.first.422
branch
from
2f88ac7 to
416db7f
Compare
|
Updated; CI builds passing |
|
🚢 🇮🇹 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$env:DNX_HOMEor$env:DNX_GLOBAL_HOMEwhen undefined$env:DNX_HOMEvalues such as ";C:\ProgramData\Microsoft DNX"nits: