This repository was archived by the owner on Dec 18, 2017. It is now read-only.
Suppress ICompilationException coming from EntryPointExecutor.Execute #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -221,13 +221,30 @@ private bool ParseArgs(string[] args, out RuntimeOptions defaultHostOptions, out | |||
| return false; | |||
| } | |||
|
|
|||
| private Task<int> ExecuteMain(DefaultHost host, string applicationName, string[] args) | |||
| private async Task<int> ExecuteMain(DefaultHost host, string applicationName, string[] args) | |||
|
I don't quite understand what this is fixing. Can you show all of the cases that cause compilation errors and how this fixes each of them? |
|
@davidfowl
I moved |
| @@ -250,8 +240,6 @@ private Task<int> ExecuteMain(DefaultHost host, string applicationName, string[] | |||
| applicationName, | |||
| ex.InnerException); | |||
| } | |||
|
|
|||
| throw; | |||
There was a problem hiding this comment.
Isn't this throw still needed? I think without this we will suppress all exceptions but FileLoad/FileNotFound and compilation exceptions...
|
🚢🇮🇹 (after you confirm we are not wrapping application exceptions in AggregateExceptions and Travis passes) |
pakrym
force-pushed
the
pakrym/2887-ExecuteMain
branch
from
63edeee to
9cd75c9
Compare
pakrym
force-pushed
the
pakrym/2887-ExecuteMain
branch
from
9cd75c9 to
1b08f54
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2887
Related to #2928
/cc @troydai @victorhurdugaci @davidfowl