Skip to content
This repository was archived by the owner on Dec 18, 2017. It is now read-only.

Use XDocument to do XML operations when generating web.config #787

Merged
merged 3 commits into from
Oct 24, 2014

Conversation

ChengTian
Copy link
Contributor

parent #778

@davidfowl , XmlReader.Create on CoreCLR always throws exception

System.Xml.XmlException: An internal error has occurred.
   at System.Xml.XmlXapResolver.GetEntity(Uri absoluteUri, String role, Type ofObjectToReturn)
   at System.Xml.XmlTextReaderImpl.FinishInitUriString()
   at System.Xml.XmlTextReaderImpl..ctor(String uriStr, XmlReaderSettings settings, XmlParserContext context, XmlResolver uriResolver)
   at System.Xml.XmlReaderSettings.CreateReader(String inputUri, XmlParserContext inputContext)
   at System.Xml.XmlReader.Create(String inputUri, XmlReaderSettings settings, XmlParserContext inputContext)
   at System.Xml.XmlReader.Create(String inputUri)
   at ConsoleApp3.Program.Main(String[] args) in C:\Users\wwa\Documents\Visual Studio Next\Projects\ConsoleApp3\src\ConsoleApp3\Program.cs:line 15

So I use

XDocument.Parse(File.ReadAllText(webConfigFilePath));

@davidfowl
Copy link
Member

Why are we still generating k.ini files? Didn't @GrabYourPitchforks move everything to web.config?

@ChengTian
Copy link
Contributor Author

This change was approved for Beta. I removed k.ini generation and added functional tests.

@davidfowl @GrabYourPitchforks , please help to review when you have time. Thanks.

@ChengTian ChengTian force-pushed the use-XDocument-for-kpm-pack-web.config-generation branch from 3accad0 to c568cbf Compare October 22, 2014 18:05
@davidfowl
Copy link
Member

:shipit:

1 similar comment
@GrabYourPitchforks
Copy link
Contributor

:shipit:

@ChengTian ChengTian force-pushed the use-XDocument-for-kpm-pack-web.config-generation branch from c568cbf to 15a95be Compare October 24, 2014 00:02
@ChengTian ChengTian merged commit 15a95be into dev Oct 24, 2014
@ChengTian ChengTian deleted the use-XDocument-for-kpm-pack-web.config-generation branch October 24, 2014 00:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants