This repository was archived by the owner on Dec 18, 2017. It is now read-only.
Made some changes to how DTH sees wrapped projects #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix up the dependencies list when returning wrapped csproj and assemblies. - Changed how unresolved dependencies were implemented. This allows a specific IDependencyProvider to say a dependency is resolved, but mark it as unresolved so that fallback does not happen. - Remove special logic from the UnresolvedDependencyProvider and made it a first class property on LibraryDescription. - Mark projects as unresolved if they do not have a compatible target framework #945
- Added new WrappedProjectPath to the ProjectReference message. This allows us to preserve all information so that editors can watch the relevant project.json and wrapped project.
|
|
||
| foreach (var d in Libraries.Where(d => !d.Resolved).OrderBy(d => d.Identity.Name)) | ||
| { | ||
| sb.AppendLine(" " + d.Identity.ToString()); |
There was a problem hiding this comment.
Why 3 spaces here? (And not 2 or 4?)
There was a problem hiding this comment.
O I C it was just copy/paste... but please fix 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assemblies.
a specific IDependencyProvider to say a dependency is resolved, but mark
it as unresolved so that fallback does not happen.
a first class property on LibraryDescription.
DTH should return .csproj file instead of wrapper project.json for references #945