BackupService: don't try to delete remote backups if no remote backup…

… has been setup

src/middleware/packages/backup/index.js

@@ -123,44 +123,40 @@ const BackupService = {
     },
     deleteDataset: {
       params: {
-        dataset: { type: 'string' },
-        iKnowWhatImDoing: { type: 'boolean' }
+        dataset: { type: 'string' }
       },
       async handler(ctx) {
-        const { dataset, iKnowWhatImDoing } = ctx.params;
+        const { dataset } = ctx.params;
         const {
           copyMethod,
           remoteServer,
           localServer: { fusekiBase }
         } = this.settings;
-        if (!iKnowWhatImDoing) {
-          throw new Error(
-            'Please confirm that you know what you are doing and set the `iKnowWhatImDoing` parameter to `true`.'
-          );
-        }
 
         const deleteFilenames = await ctx.call('backup.listBackupsForDataset', { dataset });
 
         // Delete all backups locally.
         await Promise.all(deleteFilenames.map(file => fs.promises.rm(file)));
 
         // Delete backups from remote.fusekiBase
-        switch (copyMethod) {
-          case 'rsync':
-            // The last param sets the --deletion argument, to sync deletions too.
-            await rsyncCopy(pathJoin(fusekiBase, 'backups'), 'datasets', remoteServer, true);
-            break;
-
-          case 'ftp':
-            await ftpRemove(deleteFilenames, remoteServer);
-            break;
-
-          case 'fs':
-            await fsRemove(deleteFilenames, 'datasets', remoteServer);
-            break;
-
-          default:
-            throw new Error(`Unknown copy method: ${copyMethod}`);
+        if (remoteServer.path) {
+          switch (copyMethod) {
+            case 'rsync':
+              // The last param sets the --deletion argument, to sync deletions too.
+              await rsyncCopy(pathJoin(fusekiBase, 'backups'), 'datasets', remoteServer, true);
+              break;
+
+            case 'ftp':
+              await ftpRemove(deleteFilenames, remoteServer);
+              break;
+
+            case 'fs':
+              await fsRemove(deleteFilenames, 'datasets', remoteServer);
+              break;
+
+            default:
+              throw new Error(`Unknown copy method: ${copyMethod}`);
+          }
         }
       }
     },

src/middleware/packages/backup/utils/rsyncCopy.js

@@ -12,12 +12,12 @@ const rsyncCopy = (path, subDir, remoteServer, syncDelete = false) => {
   if (syncDelete) rsync.set('delete');
 
   return new Promise((resolve, reject) => {
-    this.logger.info(`Rsync started with command: ${rsync.command()}`);
+    console.log(`Rsync started with command: ${rsync.command()}`);
     rsync.execute(error => {
       if (error) {
         reject(error);
       } else {
-        this.logger.info('Rsync finished !');
+        console.log('Rsync finished !');
         resolve();
       }
     });