Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control lexiconImportForm to avoid creating empty items #1090

Merged
merged 5 commits into from
Dec 22, 2022

Conversation

fluidlog
Copy link
Contributor

@fluidlog fluidlog commented Dec 9, 2022

Close #1089

Adding secure controls to avoid creating empty items

@fluidlog
Copy link
Contributor Author

fluidlog commented Dec 9, 2022

Ah, non, pas encore prêt, il reste un cas que je n'avais pas vu... :(

@fluidlog fluidlog added the ready label Dec 9, 2022
# Conflicts:
#	src/frontend/lerna.json
#	src/frontend/packages/activitypub-components/package.json
#	src/frontend/packages/auth-provider/package.json
#	src/frontend/packages/date-components/package.json
#	src/frontend/packages/field-components/package.json
#	src/frontend/packages/geo-components/package.json
#	src/frontend/packages/input-components/package.json
#	src/frontend/packages/interop-components/package.json
#	src/frontend/packages/list-components/package.json
#	src/frontend/packages/markdown-components/package.json
#	src/frontend/packages/semantic-data-provider/package.json
#	src/frontend/templates/cra-template-dms/package.json
@srosset81 srosset81 changed the base branch from next to master December 22, 2022 09:37
Copy link
Contributor

@srosset81 srosset81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci !
J'ai dû faire un fix sur LexiconAutocompleteInput car entre temps j'avais fait des modifications et ça causait une erreur.
Pour s'assurer de ne pas soumettre un champ vide, il suffisait d'utiliser le champ validate de React-Admin, j'ai corrigé directement.

@srosset81 srosset81 merged commit ab52648 into master Dec 22, 2022
@srosset81 srosset81 deleted the ControlLexiconImportForm branch December 22, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empêcher la création d'un item vide si on tape la touche "Entrée" dans le composant LexiconImportForm
3 participants