[field-components] MultiUrlField - Handle not-url values correctly #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srosset81
reviewed
Apr 22, 2024
mguihal
changed the title
|
@srosset81 you didn't approve this PR. Was it ok for you? Can I merge it? |
|
Yes sure ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
There is currently a bug inside MultiUrlField when value given is not a valid url (or valid urls array). The URL constructor returns an exception in that case which was not catched, causing global error on the page.
I updated the component to display the not-url value in that case (possible in Archipelago because there is no validation on edit forms)