Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set a baseUrl with a path #1279

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

srosset81
Copy link
Contributor

@srosset81 srosset81 commented Jun 25, 2024

Many SemApps services don't work if you set a baseUrl with a path, such as http://localhost:3000/api.

Unfortunately we cannot use the global path settings of Moleculer's ApiGateway, because /.well-known routes must be at the root of the domain.

So this PR parse the basePath from the baseUrl, and use it on all routes that don't start with /.well-known.

If you developed custom services, you should do that too.

@srosset81 srosset81 merged commit a9e4a18 into master Jun 25, 2024
@srosset81 srosset81 deleted the take-into-account-basepath branch June 25, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant