fix(stdin): Provide a Command wrapper #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2019 10:44
BREAKING CHANGE: `assert_cmd::cmd` was renamed to `assert_cmd::output`.
Many of our problems with `stdin` are derived from using extension traits. By moving away from them, we fix the API problems and make it easier to add other features like timeout (assert-rs#10) or signalling (assert-rs#84). So the new philosphy if: - Core functionality is provided by extension traits - Provide a convinience API that makes `Command` friendlier. These do not need to be generalized. Other abstractions can provide their own (like `duct`). Fixes assert-rs#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of our problems with
stdinare derived from using extensiontraits. By moving away from them, we fix the API problems and make it
easier to add other features like timeout (#10) or signalling (#84).
So the new philosphy if:
Commandfriendlier. These donot need to be generalized. Other abstractions can provide their own
(like
duct).Fixes #73