Merge pull request #165 from epage/revert

Revert "fix(trycmd): Error, instead of ignore, unknown bins"
assert-rs · Nov 4, 2022 · 3598ca8 · 3598ca8
2 parents 69bb3a0 + b1e51ed
commit 3598ca8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/runner.rs b/src/runner.rs
@@ -322,11 +322,16 @@ impl Case {
         }
 
         match &step.bin {
-            // Will be handled by `Step::to_command`
-            Some(crate::schema::Bin::Path(_))
-            | Some(crate::schema::Bin::Name(_))
-            | Some(crate::schema::Bin::Error(_))
-            | None => {}
+            Some(crate::schema::Bin::Path(_)) => {}
+            Some(crate::schema::Bin::Name(_name)) => {
+                // Unhandled by resolve
+                snapbox::debug!("bin={:?} not found", _name);
+                assert_eq!(output.spawn.status, SpawnStatus::Skipped);
+                return Ok(output);
+            }
+            Some(crate::schema::Bin::Error(_)) => {}
+            // Unlike `Name`, this always represents a bug
+            None => {}
             Some(crate::schema::Bin::Ignore) => {
                 // Unhandled by resolve
                 assert_eq!(output.spawn.status, SpawnStatus::Skipped);

diff --git a/tests/cmd/unresolved.trycmd b/tests/cmd/unresolved.trycmd
@@ -0,0 +1,5 @@
+Gracefully handle a non-existent name:
+```
+$ non-existent-name
+
+```