-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snapbox uses green for removed and red for added lines #228
Comments
I'm always mixed on which way to go for this. Generally, a diff will show the removed text as red and the added text as green. Here, the "good" state is the base of the diff and you generally represent "good" with "green". |
I appreciate that there is reasoning behind this decisions however I still consider the displaying of a diff with inversed colors to be incredibly confusing. Especially because both When looking at a diff from an |
I agree that |
Been thinking on this further and aligning with the common case is probably more important than the possibility of what is or isn't "right". Fixes assert-rs#228
Been thinking on this further and aligning with the common case is probably more important than the possibility of what is or isn't "right". Fixes assert-rs#228
The text was updated successfully, but these errors were encountered: