Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assert): Merge _eq and _matches via Data::raw #318

Merged
merged 6 commits into from
May 17, 2024
Merged

Conversation

epage
Copy link
Contributor

@epage epage commented May 17, 2024

With the new eq_ variants (to not break compatibility), we switched
param order as part of the path to #226

Cherry pick of #291

@epage epage enabled auto-merge May 17, 2024 15:27
@epage epage mentioned this pull request May 17, 2024
32 tasks
@coveralls
Copy link

coveralls commented May 17, 2024

Pull Request Test Coverage Report for Build 9130765280

Details

  • 54 of 78 (69.23%) changed or added relevant lines in 8 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 51.878%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/snapbox/src/harness.rs 0 1 0.0%
crates/snapbox/src/lib.rs 1 2 50.0%
crates/snapbox/src/assert/mod.rs 20 24 83.33%
crates/snapbox/src/data/source.rs 0 4 0.0%
crates/snapbox/src/cmd.rs 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
crates/snapbox/src/assert/mod.rs 3 28.57%
Totals Coverage Status
Change from base Build 9116617459: 0.9%
Covered Lines: 1340
Relevant Lines: 2583

💛 - Coveralls

@epage epage merged commit ffbdc7c into assert-rs:main May 17, 2024
14 checks passed
@epage epage deleted the eq branch May 17, 2024 15:42
epage added a commit to epage/snapbox that referenced this pull request May 17, 2024
Not a breaking change because these calls were added in assert-rs#318

Cherry pick e1cadb3 (assert-rs#292)
epage added a commit to epage/snapbox that referenced this pull request May 17, 2024
Not a breaking change because `Inline::raw` was exposed in assert-rs#318

Cherry pick 732fad9 (assert-rs#292)
epage added a commit to epage/snapbox that referenced this pull request May 17, 2024
Not a breaking change because these calls were added in assert-rs#318

Cherry pick e1cadb3 (assert-rs#292)
epage added a commit to epage/snapbox that referenced this pull request May 17, 2024
Not a breaking change because `Inline::raw` was exposed in assert-rs#318

Cherry pick 732fad9 (assert-rs#292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants