Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snap)!: Re-integrate breaking changes #329

Merged
merged 28 commits into from
May 23, 2024
Merged

fix(snap)!: Re-integrate breaking changes #329

merged 28 commits into from
May 23, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented May 23, 2024

Fixes #311

epage added 28 commits May 23, 2024 15:28
@epage
fix(snap)!: Remove deprecated APIs
c06fa94 
Cherry pick 86fa504 (assert-rs#275)
Cherry pick 3ddd841 (assert-rs#290)
@epage
fix(snap): Deprecate eq_ in favor of eq fn's
afadbca
@epage
fix(snap)!: Remove indent support
ffca2b6 
Rather than dealing with the special cases where this doesn't exist,
let's just not do this.

This also aligns with the general style within Cargo's tests.

Fixes assert-rs#267

Cherry pick 20d65cd (assert-rs#271)
@epage
fix(snap)!: Include a trailing newline in snapshots
0b77043 
In using snapshots, I found the leading newline so good that I feel like
we should have a trailing newline as well!

Cherry pick 7fbcc9c (assert-rs#272)
@epage
fix(snap)!: Allow adding formats without breaking compatibility
70bcbd0 
Cherry pick 81796c5 (assert-rs#278)
@epage
feat(snap): Jsonlines support
7b9f98b 
Looks like ndjson was merged into jsonlines, so went with that.

One difference at one point was allowing blank lines from what I've
heard.  I'm not seeing it mentioned in jsonlines but went with
supporting it.

Part of assert-rs#92

Cherry pick ae6bce4 (assert-rs#277)
Cherry pick 62ddc26 (assert-rs#290)
@epage
test(snap): Verify data formats
264cd35 
Cherry pick e7ef941 (assert-rs#277)
@epage
fix(snap): Change how we normalize matches
2682c53 
There isn't a succinct way to describe this set of changes.

Know changes:
- You can now end a `...` with a line containing `[..]`
- Variables are always substituted, rather than only when used in the
  pattern
- We don't try as hard to recover from diverging input/pattern

Cherry pick 06d6a0f (assert-rs#279)
@epage
fix(filter)!: Allow additional redacted value types
ea6f146 
Cherry pick 286ac5d (assert-rs#281)
@epage
feat(filter): Allow regexes for substitutions
3570cc3 
Cherry pick b5220cd (assert-rs#281)
Cherry pick 38c4fb8 (assert-rs#285)
@epage
docs(filter): Improve Redactions docs
e3e5813
@epage
feat(filters): Allow paths as redacted values
4a8e317 
Cherry pick 0841264 (assert-rs#286)
@epage
fix(filters)!: Dont normalize all redactions
0a50353 
Cherry pick 34272b3 (assert-rs#286)
@epage
refactor(filter): Simplify Redactions
4026b9a
@epage
fix(data)!: Clarify what types are supported
1d52e24 
Cherry pick fb14410  (assert-rs#292)
@epage
refactor(filter): Clarify variable names
b332ee4
@epage
test(filter): Show overlapping redactions problem
763bb2d
@epage
fix(filter): Prioritize more-specific (longer, non-regex) Redactions
1229d33
@epage
test(filter): Show incomplete redacting on json
c178cf8
@epage
fix(filter): Still redact json values on mismatch
2cba34f
@epage
test(filter): Show object key filtering
71c99cf
@epage
fix(filter)!: Apply basic filters to json keys
1a21cc2
@epage
test(filter): Show redactions not applying to keys
ed482c3
@epage
fix(filter)!: Redact json keys
23bad1f
@epage
test(filter): Show lack of key wildcard
7f4b5da
@epage
docs(filter): Cover json value wildcard
9a873fa
@epage
feat(filter)!: Allow key wildcards
4c1e2c0 
Fixes assert-rs#134
@epage
feat(filter): Expose Redactions::redact
a9cc0e4
@coveralls
Copy link

coveralls commented May 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9214557670

Details

  • 82 of 134 (61.19%) changed or added relevant lines in 9 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.6%) to 51.356%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/snapbox/src/assert/mod.rs 1 3 33.33%
crates/snapbox/src/data/runtime.rs 4 7 57.14%
crates/trycmd/src/cases.rs 5 8 62.5%
crates/snapbox/src/cmd.rs 0 6 0.0%
crates/snapbox/src/data/mod.rs 10 26 38.46%
crates/snapbox/src/filter/redactions.rs 55 77 71.43%
Files with Coverage Reduction New Missed Lines %
crates/snapbox/src/filter/redactions.rs 1 81.43%
crates/snapbox/src/data/source.rs 1 35.29%
crates/snapbox/src/data/mod.rs 3 50.79%
crates/snapbox/src/data/runtime.rs 3 53.59%
Totals Coverage Status
Change from base Build 9214415103: 0.6%
Covered Lines: 1307
Relevant Lines: 2545
💛 - Coveralls

@epage epage merged commit 7269940 into assert-rs:main May 23, 2024
15 of 16 checks passed
@epage epage deleted the break branch May 23, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-integrate abandoned merged PRs
2 participants
@epage @coveralls