feat(cases): add a boolean flag to return Error in case the binary was not resolved #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the issue where this is being discussed is #105. |
Pull Request Test Coverage Report for Build 14592626116Details
💛 - Coveralls |
|
I posted my follow up thoughts on this solution in #105 (I try to reserve PRs only for reviewing implementation) |
veeso
force-pushed
the
option-to-fail-if-binary-not-found
branch
from
fda4657 to
eef0787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
At Bitfinity we had this issue where we moved the tool we were testing and for literally months we didn't notice the tests were ignored, because our CI is huge.
I think that providing the possibility to fail in case the binary was not resolved would be very good for many users.
In this PR I've added a boolean flag to make the case to fail in case the binary was not resolved.
I'm open to any style change on the code I've written.