-
-
Notifications
You must be signed in to change notification settings - Fork 708
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add varargs overload to Assert#hasString and Assert#doesNotHaveString
This overload will delegate to String#format internally, similar to how StringAssert#isEqualTo allows for string templating expansion. This removes the need to write manual formatting in tests that need to consume a fixture placeholder.
- Loading branch information
Showing
4 changed files
with
138 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
...t/java/org/assertj/core/api/abstract_/AbstractAssert_doesNotHaveToString_format_Test.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on | ||
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations under the License. | ||
* | ||
* Copyright 2012-2023 the original author or authors. | ||
*/ | ||
package org.assertj.core.api.abstract_; | ||
|
||
import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
import static org.mockito.Mockito.verify; | ||
|
||
import org.assertj.core.api.AbstractAssertBaseTest; | ||
import org.assertj.core.api.ConcreteAssert; | ||
import org.junit.jupiter.api.Test; | ||
|
||
/** | ||
* @author Ashley Scopes | ||
*/ | ||
class AbstractAssert_doesNotHaveToString_format_Test extends AbstractAssertBaseTest { | ||
|
||
@Override | ||
protected ConcreteAssert invoke_api_method() { | ||
return assertions.doesNotHaveToString("%s %s", "some", "description"); | ||
} | ||
|
||
@Override | ||
protected void verify_internal_effects() { | ||
verify(objects).assertDoesNotHaveToString(getInfo(assertions), getActual(assertions), "some description"); | ||
} | ||
|
||
@Test | ||
void nullStringArgumentsThrowAnException() { | ||
assertThatThrownBy(() -> assertions.doesNotHaveToString(null, "foo", "bar")) | ||
.isInstanceOf(NullPointerException.class) | ||
.hasMessage("The expectedStringTemplate must not be null"); | ||
} | ||
} |
43 changes: 43 additions & 0 deletions
43
.../src/test/java/org/assertj/core/api/abstract_/AbstractAssert_hasToString_format_Test.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on | ||
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations under the License. | ||
* | ||
* Copyright 2012-2023 the original author or authors. | ||
*/ | ||
package org.assertj.core.api.abstract_; | ||
|
||
import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
import static org.mockito.Mockito.verify; | ||
|
||
import org.assertj.core.api.AbstractAssertBaseTest; | ||
import org.assertj.core.api.ConcreteAssert; | ||
import org.junit.jupiter.api.Test; | ||
|
||
/** | ||
* {@author Ashley Scopes} | ||
*/ | ||
class AbstractAssert_hasToString_format_Test extends AbstractAssertBaseTest { | ||
|
||
@Override | ||
protected ConcreteAssert invoke_api_method() { | ||
return assertions.hasToString("%s %s", "some", "description"); | ||
} | ||
|
||
@Override | ||
protected void verify_internal_effects() { | ||
verify(objects).assertHasToString(getInfo(assertions), getActual(assertions), "some description"); | ||
} | ||
|
||
@Test | ||
void nullStringArgumentsThrowAnException() { | ||
assertThatThrownBy(() -> assertions.hasToString(null, "foo", "bar")) | ||
.isInstanceOf(NullPointerException.class) | ||
.hasMessage("The expectedStringTemplate must not be null"); | ||
} | ||
} |