Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isPrimitive and isNotPrimitive to Class assertions #2722

Closed
wants to merge 3 commits into from
Closed

Add isPrimitive and isNotPrimitive to Class assertions #2722

wants to merge 3 commits into from

Conversation

ManuelG28
Copy link

Check List:

joel-costigliola
joel-costigliola requested changes Jul 31, 2022
View reviewed changes
Copy link
Member

@joel-costigliola joel-costigliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ManuelG28, first round of code review done. PR looks good, just some minor/improvements comments to address.

assertj-core/src/main/java/org/assertj/core/api/AbstractClassAssert.java Outdated Show resolved Hide resolved
assertj-core/src/main/java/org/assertj/core/api/AbstractClassAssert.java Outdated Show resolved Hide resolved
assertj-core/src/test/java/org/assertj/core/api/classes/ClassAssert_isNotPrimitive_Test.java Outdated Show resolved Hide resolved
assertj-core/src/test/java/org/assertj/core/api/classes/ClassAssert_isNotPrimitive_Test.java Outdated Show resolved Hide resolved
assertj-core/src/test/java/org/assertj/core/api/classes/ClassAssert_isPrimitive_Test.java Outdated Show resolved Hide resolved
...-core/src/test/java/org/assertj/core/internal/classes/Classes_assertIsNotPrimitive_Test.java Outdated Show resolved Hide resolved
...rtj-core/src/test/java/org/assertj/core/internal/classes/Classes_assertIsPrimitive_Test.java Outdated Show resolved Hide resolved
@ManuelG28
Copy link
Author

Hi, @joel-costigliola thanks for the information about @ParameterizedTest.
I have learned something new today!

Please let me know if I need to change something else.

@scordio scordio force-pushed the main branch 2 times, most recently from 38c7b4b to 3cde5bf Compare July 20, 2023 15:21
@scordio scordio added this to the 3.25.0 milestone Sep 16, 2023
@scordio scordio mentioned this pull request Sep 16, 2023
Closed
@joel-costigliola joel-costigliola self-assigned this Sep 29, 2023
@joel-costigliola
Copy link
Member

Integrated thanks @ManuelG28 !

@scordio scordio changed the title Add AbstractClassAssert#isPrimitive() and AbstractClassAssert#isNotPrimitive() Add isPrimitive and isNotPrimitive to Class assertions Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joel-costigliola joel-costigliola Awaiting requested review from joel-costigliola

Assignees

@joel-costigliola joel-costigliola

Labels
None yet
Projects
None yet
Milestone
3.25.0
Development

Successfully merging this pull request may close these issues.

Add AbstractClassAssert#is(Not)Primitive()
3 participants
@ManuelG28 @joel-costigliola @scordio