Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update misleading parameter name AbstractOffsetDateTimeAssert#isBetween #3217

Merged

Conversation

radistao
Copy link
Contributor

AbstractOffsetDateTimeAssert#isBetween should use inclusive, not exclusive

Also checked other Date/Time asserts and tests: seems like in other classes the parameter names are valid.

Check List:

  • Fixes: chore argument renaming
  • Unit tests : NA
  • Javadoc with a code example (on API only) : NA (autogenerated)
  • PR meets the contributing guidelines

Following the contributing guidelines will make it easier for us to review and accept your PR.

* AbstractOffsetDateTimeAssert#isBetweenshould use `inclusive`, not `exclusive`
@joel-costigliola
Copy link
Member

joel-costigliola commented Oct 11, 2023

@radistao good catch! there are still a few references to exclusive to update in the javadoc

@joel-costigliola joel-costigliola merged commit 519761d into assertj:main Oct 12, 2023
11 checks passed
@joel-costigliola
Copy link
Member

Integrated thanks @radistao !

@joel-costigliola joel-costigliola added this to the 3.25.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants