Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Instant conversion with Date assertions #3467

Merged
merged 1 commit into from
May 20, 2024

Conversation

scordio
Copy link
Member

@scordio scordio commented May 9, 2024

This also reverts the changes introduced with #3410.

Fixes #3359.

@scordio scordio added this to the 3.26.0 milestone May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@scordio scordio force-pushed the gh-3359-date-compared-with-instant-nanos branch 2 times, most recently from 755e614 to 16920fc Compare May 9, 2024 19:02
@scordio scordio changed the title Fix Instant and String conversion with Date assertions Fix Instant conversion with Date assertions May 9, 2024
This reverts the changes introduced with #3410.
@scordio scordio force-pushed the gh-3359-date-compared-with-instant-nanos branch from 04595db to f74ff83 Compare May 20, 2024 09:47
@scordio scordio marked this pull request as ready for review May 20, 2024 09:47
@scordio scordio merged commit 99f2991 into 3.x May 20, 2024
21 checks passed
@scordio scordio deleted the gh-3359-date-compared-with-instant-nanos branch May 20, 2024 09:54
genuss pushed a commit to genuss/assertj that referenced this pull request May 28, 2024
This also reverts the changes introduced with assertj#3410.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to compare some timestamp types
2 participants