Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Clear all Entries" function #214

Merged
merged 6 commits into from
Jul 4, 2022

Conversation

mrpbdy
Copy link
Contributor

@mrpbdy mrpbdy commented Jul 1, 2022

Because the EntryList upload appends the new list to any existing Entries, the user has to individually remove all entries before uploading a new list.
To alleviate that in a 48car field :) I added a 'Clear all Entries' function and button to entrylist.vue. I hope it is useful. (I have done the same for Sessions, but will await feedback)

@pedrofaria
Copy link
Collaborator

Nice idea!

Can you add the same thing to sessions in Event Settings tab and BOP Settings?

@mrpbdy
Copy link
Contributor Author

mrpbdy commented Jul 1, 2022

Done and tested

@pedrofaria
Copy link
Collaborator

Awesome... I have the feeling that this is a critical action, WDYT to add a simple confirmation with window.confirm before remove the list ?

I am wondering if someone press this button by mistake and remove all configuration... will be really bad!

@mrpbdy
Copy link
Contributor Author

mrpbdy commented Jul 2, 2022

A thought - Should I also disable the buttons for Read Only users?

Copy link
Contributor Author

@mrpbdy mrpbdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs work - please ignore this commit for now - will submit changes tomorrow

@pedrofaria
Copy link
Collaborator

A thought - Should I also disable the buttons for Read Only users?

Could be interesting to avoid confusion.... read only users will not be able to save anyway

@pedrofaria pedrofaria merged commit f3178b7 into assetto-corsa-web:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants