Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ui-negative-number in ui-percentage-mask #220

Closed
wants to merge 5 commits into from
Closed

Allow ui-negative-number in ui-percentage-mask #220

wants to merge 5 commits into from

Conversation

Konageski
Copy link

In percentage mask, analise the tag ui-negative-number e correct value
and mask

In percentage mask, analise the tag ui-negative-number e correct value
and mask
In percentage mask, analise the tag ui-negative-number and correct the
value and mask
In percentage mask, analise the tag ui-negative-number and correct the
value and mask
In percentage mask, analise the tag ui-negative-number e correct value
and mask
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 96.388% when pulling 1aea674 on Konageski:master into 2ea6056 on assisrafael:master.

In percentage mask, analise the tag ui-negative-number e correct value
and mask
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 96.571% when pulling 790f8a4 on Konageski:master into 2ea6056 on assisrafael:master.

@assisrafael
Copy link
Owner

I'm not sure about this change.
Can you implement a test case that shows the behavior you need?

@Konageski
Copy link
Author

Today is not possible to use negative number in percentage-mask field.
This change able to use ui-negative-number in ui-percentage-mask field.
I use this change in my system.

<input type="text" name="negativePercentage" ng-model="obj.negativePercentage" class="form-control" ui-percentage-mask="2" **ui-negative-number** required>
image

@guylhermetabosa
Copy link

This definitely should be available in this lib. Thanks @Konageski.

@assisrafael
Copy link
Owner

Replaced by #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants