Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smarti End-to-End-test #84

Closed
2 tasks
mrsimpson opened this issue Oct 10, 2017 · 0 comments · Fixed by #301
Closed
2 tasks

Smarti End-to-End-test #84

mrsimpson opened this issue Oct 10, 2017 · 0 comments · Fixed by #301
Assignees
@ThomasRoehl @mrsimpson
Labels
Priority: High Type: Test

Comments

@mrsimpson
Copy link
Member

mrsimpson commented Oct 10, 2017 •
edited
Loading

Context

In order to ensure consistency in upgrades, we are in need of automated tests.
Though Smarti has got some unit-tests itself, integration tests are missing.

Scenario

The "end" in end-to-end in the context of Assistify is Rocket.Chat =>
Implement tests, both for the API as well as for the UI in our RC-fork.

This story is not about comprehensive test-suite-creation, but is complete once the following succeeds

DoD

  • Via RC REST-API: Create a topic, create a corresponding request, create some messages, ensure the conversation being stored in Smarti
  • Via the UI: Make sure the Smarti-Widget is being loaded once the Assistify-tab is expanded
@mrsimpson mrsimpson mentioned this issue Oct 10, 2017
Closed
vickyokrm pushed a commit that referenced this issue Oct 19, 2017
@mrsimpson
Make fix for input selection more robust (#84)
15a18a8 
* use Meteor's internal selector instead of a global jQuery

* Make the focus input event a bit more robust

* Undo accidental cut

* code style
@mrsimpson mrsimpson mentioned this issue Mar 31, 2018
Merged
@ghost ghost assigned mrsimpson Mar 31, 2018
@ghost ghost removed the progress:working label Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasRoehl ThomasRoehl

@mrsimpson mrsimpson

Labels
Priority: High Type: Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate message lifecycle to Smarti assistify/Rocket.Chat
2 participants
@ThomasRoehl @mrsimpson