-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/optional version and add store without version increment #434
Feature/optional version and add store without version increment #434
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @0xrgg, I will check this PR as soon as possible. |
Hi @0xrgg, |
Hi @aparzi - the real usage in my case is creating a new store dynamically, which I believe is already implemented in the playground, however doing this with the current main code results in a version error in the console which is what @irsali was trying to say in his original PR (I believe). Also when you rebuild the project, you also get this error and in my case the app is unable to start as it's part of the pre-flight checks to retrieve stored data. I did try to get the playground running to confirm but throwing up compiler errors on my side, though I did do a build and placed it into my dependent project to test my changes at the time I was trying to figure out a way to check and set the config on the fly but was unable to figure it out and it was blocking my progress on the project consuming the package, I may revisit in future and try again though. |
@0xrgg ok perfect. |
@0xrgg I had a chance to try it and it seems ok. I understand the problem. Thanks for your support. |
@assuncaocharles - didn't want to create a duplicate PR but original author seems to have been absent this week so pulled his repo and added the version change as requested, let me know if I missed anything and will get it resolved ASAP.
For cases where store gets created dynamically and version is not required to be updated.
From Original PR: #423 by @irsali