Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Use cimg/node instead of circleci/node in CircleCI config #1038

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

deraw
Copy link
Member

@deraw deraw commented Apr 21, 2021

Description

Utilisation de l'image cimg/node à la place de circle/node.

(Voir codecov/codecov-circleci-orb#77 (comment))

Type de changement

  • Maintenance

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@deraw deraw added the internal label Apr 21, 2021
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #1038 (4ce1cc6) into dev (cc7712f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1038   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          128       128           
  Lines         1014      1014           
  Branches       144       144           
=========================================
  Hits          1014      1014           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7712f...4ce1cc6. Read the comment docs.

@deraw deraw merged commit 7a809f1 into dev Apr 21, 2021
@deraw deraw deleted the internal/circle-ci-node-image branch April 21, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant