Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ form-builder: Remove deprecated VLayout usage in PeriodField #1081

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

deraw
Copy link
Member

@deraw deraw commented Apr 30, 2021

Description

Suppression de l'utilisation du composant VLayout déprécié dans le composant PeriodField.

Playground

<template>
	<div>
		<FormField v-model="field" />
	</div>
</template>

<script lang="ts">
	import Vue from 'vue';
	import Component from 'vue-class-component';

	@Component
	export default class Playground extends Vue {
		field = {
			type: 'period',
			value: {
				from: null,
				to: null
			},
			fieldOptions: {
				from: {
					label: 'Début',
					outlined: true
				},
				to: {
					label: 'Fin',
					outlined: true
				}
			}
		};
	}
</script>

Type de changement

  • Refactoring

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@deraw deraw added this to the v2.0.0-beta.10 milestone Apr 30, 2021
@deraw deraw force-pushed the form-builder/refactor/period-field-layout branch from 9236ef5 to 24b23c8 Compare April 30, 2021 17:40
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1081 (24b23c8) into dev (011f6e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1081   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          127       127           
  Lines         1024      1024           
  Branches       147       147           
=========================================
  Hits          1024      1024           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011f6e9...24b23c8. Read the comment docs.

@deraw deraw merged commit a860b26 into dev Apr 30, 2021
@deraw deraw deleted the form-builder/refactor/period-field-layout branch April 30, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant