Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ form-builder: Update RangeField input order #1147

Merged
merged 3 commits into from
Jun 1, 2021
Merged

Conversation

PYKEngine
Copy link
Contributor

Description

Inversion des champs d'input min et max dans le composant range field afin d'améliorer le confort d'utilisation

Type de changement

  • Correction de bug

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@PYKEngine PYKEngine changed the title 🔧 range-field: Update range-field input order (#1134) 🔧 form-builder: Update range-field input order (#1134) Jun 1, 2021
@deraw deraw changed the title 🔧 form-builder: Update range-field input order (#1134) ♻️ form-builder: Update RangeField input order Jun 1, 2021
@deraw deraw linked an issue Jun 1, 2021 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #1147 (b5a57e4) into dev (1e30311) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1147   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          136       136           
  Lines         1039      1039           
  Branches       147       147           
=========================================
  Hits          1039      1039           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e30311...b5a57e4. Read the comment docs.

@deraw deraw merged commit 0d46584 into dev Jun 1, 2021
@deraw deraw deleted the range-field-fix branch June 1, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inverser les champs de valeur min et max dans le RangeField
2 participants