Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 form-builder: Fix input width in PeriodField #1208

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

deraw
Copy link
Member

@deraw deraw commented Jul 5, 2021

Description

Correction de la largeur des champs dans le composant PeriodField.

Playground

<template>
	<FormField v-model="field" />
</template>

<script lang="ts">
	import Vue from 'vue';
	import Component from 'vue-class-component';

	import { Field } from '@cnamts/form-builder/src/components/FormField/types';

	@Component
	export default class FormFieldPeriod extends Vue {
		field: Field = {
			type: 'period',
			value: {
				from: null,
				to: null
			},
			fieldOptions: {
				from: {
					label: 'Début',
					outlined: true
				},
				to: {
					label: 'Fin',
					outlined: true
				}
			}
		};
	}
</script>

Type de changement

  • Correction de bug

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@deraw deraw added the bug Correction de bug label Jul 5, 2021
@deraw deraw force-pushed the form-builder/fix/period-field-styles branch from 9c66647 to f6a7bf9 Compare July 5, 2021 09:31
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #1208 (f6a7bf9) into dev (9338b22) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1208   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          140       140           
  Lines         1049      1049           
  Branches       147       147           
=========================================
  Hits          1049      1049           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9338b22...f6a7bf9. Read the comment docs.

@deraw deraw merged commit a1ef419 into dev Jul 5, 2021
@deraw deraw deleted the form-builder/fix/period-field-styles branch July 5, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Correction de bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant