Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 vue-dot: Fix menu position in ExternalLinks #1263

Merged
merged 23 commits into from
Jul 27, 2021
Merged

🐛 vue-dot: Fix menu position in ExternalLinks #1263

merged 23 commits into from
Jul 27, 2021

Conversation

mmi16389
Copy link
Contributor

@mmi16389 mmi16389 commented Jul 19, 2021

Description

Correction du menu externalLinks

  • Quand le bouton menu, est positionné sur une page il y a un decalage de 12px

Playground

<template>
	<ExternalLinks
		:items="links"
		position="top left"
	>
		<template #link-icon>
			<VIcon>
				{{ arrowIcon }}
			</VIcon>
		</template>
	</ExternalLinks>
</template>

<script lang="ts">
	import Vue from 'vue';
	import Component from 'vue-class-component';

	import { ExternalLink } from '@cnamts/vue-dot/src/elements/ExternalLinks/types';

	import { mdiArrowTopRight } from '@mdi/js';

	@Component
	export default class ExternalLinksSlots extends Vue {
		arrowIcon = mdiArrowTopRight;

		links: ExternalLink[] = [
			{
				href: 'https://ameli.fr/',
				text: 'Ameli'
			},
			{
				href: 'https://espacepro.ameli.fr/',
				text: 'Ameli Pro'
			},
			{
				href: 'https://github.com/assurance-maladie-digital',
				text: 'Design System'
			}
		];
	}
</script>

Type de changement

  • Correction de bug

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@mmi16389 mmi16389 requested review from deraw and PYKEngine July 19, 2021 07:57
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #1263 (5c983ff) into dev (670a498) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1263   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       142           
  Lines         1053      1053           
  Branches       147       147           
=========================================
  Hits          1053      1053           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 670a498...5c983ff. Read the comment docs.

Copy link
Member

@deraw deraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que tu peux mettre à jour le changelog aussi stp ?

@deraw deraw changed the title Bug fix/1223 🐛 vue-dot: Fix menu position in ExternalLinks Jul 22, 2021
mmi16389 and others added 6 commits July 22, 2021 16:52
@deraw deraw linked an issue Jul 27, 2021 that may be closed by this pull request
@deraw deraw merged commit 4581e8e into dev Jul 27, 2021
@deraw deraw deleted the bugFix/1223 branch July 27, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corriger le positionnement du menu dans l'élément ExternalLinks
4 participants