Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿️ vue-dot: Add ARIA role attribute on NotificationBar #1509

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

deraw
Copy link
Member

@deraw deraw commented Oct 18, 2021

Description

Ajout de l'attribut ARIA role au composant NotificationBar.
(voir https://developer.mozilla.org/fr/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_status_role)

Type de changement

  • Correction de bug

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@deraw deraw added the bug Correction de bug label Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #1509 (c212c74) into dev (a6115cb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1509   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       142           
  Lines         1053      1053           
  Branches       147       147           
=========================================
  Hits          1053      1053           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6115cb...c212c74. Read the comment docs.

@deraw deraw merged commit 56cf6e7 into dev Oct 18, 2021
@deraw deraw deleted the vue-dot/a11y/notification-bar-status branch October 18, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Correction de bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant