Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ vue-dot: Add Logo element #1527

Merged
merged 3 commits into from
Oct 22, 2021
Merged

✨ vue-dot: Add Logo element #1527

merged 3 commits into from
Oct 22, 2021

Conversation

deraw
Copy link
Member

@deraw deraw commented Oct 21, 2021

Description

Ajout du composant Logo.

Type de changement

  • Nouvelle fonctionnalité
  • Documentation

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

deraw and others added 2 commits October 22, 2021 10:15
Co-authored-by: Aubin Mottier <56488255+Kelhel@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #1527 (702a53b) into dev (5bc97c3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1527   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          144       148    +4     
  Lines         1067      1078   +11     
  Branches       148       148           
=========================================
+ Hits          1067      1078   +11     
Impacted Files Coverage Δ
packages/vue-dot/src/elements/Logo/LogoSizeEnum.ts 100.00% <100.00%> (ø)
packages/vue-dot/src/elements/Logo/index.ts 100.00% <100.00%> (ø)
packages/vue-dot/src/elements/Logo/locales.ts 100.00% <100.00%> (ø)
...vue-dot/src/elements/Logo/logoDimensionsMapping.ts 100.00% <100.00%> (ø)
packages/vue-dot/src/elements/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc97c3...702a53b. Read the comment docs.

@deraw deraw merged commit b20e576 into dev Oct 22, 2021
@deraw deraw deleted the vue-dot/feature/logo branch October 22, 2021 08:21
@mmi16389 mmi16389 self-requested a review October 22, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants