Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 form-builder: Handle other field error messages in ChoiceField #1560

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

deraw
Copy link
Member

@deraw deraw commented Oct 25, 2021

Description

Correction de la gestion des messages d'erreur dans le composant ChoiceField.

Type de changement

  • Correction de bug

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@deraw deraw added the bug Correction de bug label Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1560 (b61e7e0) into dev (26bda12) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1560   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          161       161           
  Lines         1115      1115           
  Branches       150       150           
=========================================
  Hits          1115      1115           
Impacted Files Coverage Δ
...src/components/FormField/mixins/choiceComponent.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26bda12...b61e7e0. Read the comment docs.

@deraw deraw linked an issue Oct 26, 2021 that may be closed by this pull request
@deraw deraw merged commit 93911f4 into dev Oct 26, 2021
@deraw deraw deleted the form-builder/fix/choice-field-error-messages branch October 26, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Correction de bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Les erreurs ne s'affichent pas sur les champs de type select
1 participant