Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 vue-dot: Fix value not reset without v-model #1646

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

deraw
Copy link
Member

@deraw deraw commented Dec 8, 2021

Description

Correction de la valeur du composant DatePicker mal réinitialisée sans v-model.

Type de changement

  • Correction de bug

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@deraw deraw force-pushed the vue-dot/fix/date-picker-value-reset branch from 0258de7 to 1cd5ddf Compare December 8, 2021 14:08
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1646 (1cd5ddf) into dev (23389a0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1646   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          162       162           
  Lines         1116      1119    +3     
  Branches       150       150           
=========================================
+ Hits          1116      1119    +3     
Impacted Files Coverage Δ
...ue-dot/src/patterns/DatePicker/mixins/dateLogic.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23389a0...1cd5ddf. Read the comment docs.

@deraw deraw merged commit bcd5dc9 into dev Dec 8, 2021
@deraw deraw deleted the vue-dot/fix/date-picker-value-reset branch December 8, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant