Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ vue-dot: Add label prop in CustomIcon #1661

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

deraw
Copy link
Member

@deraw deraw commented Dec 12, 2021

Description

Ajout de la prop label au composant CustomIcon.

Playground

<template>
	<CustomIcon
		icon="digital"
		label="Logo de la filière Digital"
	/>
</template>

<script lang="ts">
	import Vue from 'vue';
	import Component from 'vue-class-component';

	@Component
	export default class Playground extends Vue {}
</script>

Type de changement

  • Nouvelle fonctionnalité
  • Ce changement nécessite une mise à jour de la documentation

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #1661 (0246faf) into dev (131ba58) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1661   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          166       166           
  Lines         1145      1145           
  Branches       155       155           
=========================================
  Hits          1145      1145           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131ba58...0246faf. Read the comment docs.

@deraw deraw merged commit 34c23b2 into dev Dec 13, 2021
@deraw deraw deleted the vue-dot/feat/custom-icon-label branch December 13, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant