Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 vue-dot: Fix menu display with text-field-activator in DatePicker #1678

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

deraw
Copy link
Member

@deraw deraw commented Dec 17, 2021

Description

Correction de l'affichage du menu avec la prop text-field-activator.

Actuellement, avec la prop text-field-activator, seul la zone bleue de gauche affiche le menu.
Avec ce correctif, toute la zone bleue et la zone verte affichent maintenant le menu.

Capture d’écran 2021-12-17 144338

Playground

<template>
	<DatePicker
		outlined
		text-field-activator
		text-field-class="vd-form-input"
	/>
</template>

<script lang="ts">
	import Vue from 'vue';
	import Component from 'vue-class-component';

	@Component
	export default class Playground extends Vue {}
</script>

Type de changement

  • Correction de bug

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #1678 (28a5cda) into dev (b18214c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1678   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          166       166           
  Lines         1145      1145           
  Branches       155       155           
=========================================
  Hits          1145      1145           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18214c...28a5cda. Read the comment docs.

@deraw deraw merged commit f50dad2 into dev Dec 17, 2021
@deraw deraw deleted the vue-dot/fix/date-picker-text-field-activator branch December 17, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant