Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ vue-dot: Refactor menu button on mobile in HeaderNavigationBar #1726

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

deraw
Copy link
Member

@deraw deraw commented Jan 17, 2022

Description

Refonte du bouton pour activer le menu sur les écrans mobiles dans le composant HeaderNavigationBar.

Playground

<template>
	<HeaderBar :navigation-items="navigationItems" />
</template>

<script lang="ts">
	import Vue from 'vue';
	import Component from 'vue-class-component';

	import { NavigationItem } from '@cnamts/vue-dot/src/patterns/HeaderBar/types';

	@Component
	export default class Playground extends Vue {
		navigationItems: NavigationItem[] = [
			{
				label: 'Accueil'
			},
			{
				label: 'Mes projets'
			},
			{
				label: 'Mes outils'
			}
		];
	}
</script>

Type de changement

  • Refactoring

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #1726 (330c0cb) into dev (d06aca0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1726   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          166       166           
  Lines         1145      1145           
  Branches       155       155           
=========================================
  Hits          1145      1145           
Impacted Files Coverage Δ
...c/patterns/HeaderBar/HeaderNavigationBar/config.ts 100.00% <ø> (ø)
.../patterns/HeaderBar/HeaderNavigationBar/locales.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06aca0...330c0cb. Read the comment docs.

@deraw deraw merged commit 50e0938 into dev Jan 17, 2022
@deraw deraw deleted the vue-dot/refactor/header-bar-menu-btn branch January 17, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant